tailscale/wgengine
Andrew Dunham 6540d1f018 wgengine/router: look up absolute path to netsh.exe on Windows
This is in response to logs from a customer that show that we're unable
to run netsh due to the following error:

    router: firewall: adding Tailscale-Process rule to allow UDP for "C:\\Program Files\\Tailscale\\tailscaled.exe" ...
    router: firewall: error adding Tailscale-Process rule: exec: "netsh": cannot run executable found relative to current directory:

There's approximately no reason to ever dynamically look up the path of
a system utility like netsh.exe, so instead let's first look for it
in the System32 directory and only if that fails fall back to the
previous behaviour.

Updates #10804

Signed-off-by: Andrew Dunham <andrew@du.nham.ca>
Change-Id: I68cfeb4cab091c79ccff3187d35f50359a690573
2024-01-10 20:20:19 -05:00
..
bench tailcfg, all: use []netip.AddrPort instead of []string for Endpoints 2023-10-01 18:23:02 -07:00
capture various: add golangci-lint, fix issues (#7905) 2023-04-17 18:38:24 -04:00
filter wgengine/filter: add protocol-agnostic packet checker (#10446) 2023-12-02 16:30:33 -06:00
magicsock wgengine/magicsock: fix typos in docs (#10729) 2024-01-03 10:50:38 -08:00
netlog wgengine/netlog: fix nil pointer dereference in logtail (#8598) 2023-07-13 08:54:29 -07:00
netstack wgengine/netstack: disable RACK on Windows (#10402) 2023-11-28 12:12:32 -08:00
router wgengine/router: look up absolute path to netsh.exe on Windows 2024-01-10 20:20:19 -05:00
wgcfg cmd/cloner,*: revert: optimize nillable slice cloner 2023-09-29 18:18:18 -07:00
wgint all: update copyright and license headers 2023-01-27 15:36:29 -08:00
wglog all: update copyright and license headers 2023-01-27 15:36:29 -08:00
winnet all: update copyright and license headers 2023-01-27 15:36:29 -08:00
mem_ios.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
pendopen.go types/netmap, all: use read-only tailcfg.NodeView in NetworkMap 2023-08-18 20:04:35 -07:00
userspace.go all: cleanup unused code, part 1 (#10661) 2023-12-20 14:50:30 -08:00
userspace_ext_test.go tsd: add package with System type to unify subsystem init, discovery 2023-05-04 14:21:59 -07:00
userspace_test.go control,tailcfg,wgengine/magicsock: add nodeAttr to enable/disable peer MTU 2023-09-21 04:17:12 -07:00
watchdog.go wgengine, proxymap: split out port mapping from Engine to new type 2023-09-17 20:06:43 +01:00
watchdog_js.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
watchdog_test.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
wgengine.go wgengine, proxymap: split out port mapping from Engine to new type 2023-09-17 20:06:43 +01:00