diff --git a/lib/user.pm b/lib/user.pm index 680290b..8bbd82b 100644 --- a/lib/user.pm +++ b/lib/user.pm @@ -1,7 +1,7 @@ # # Monitorix - A lightweight system monitoring tool. # -# Copyright (C) 2005-2016 by Jordi Sanfeliu +# Copyright (C) 2005-2017 by Jordi Sanfeliu # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -161,6 +161,7 @@ sub user_update { sub user_cgi { my ($package, $config, $cgi) = @_; + my @output; my $user = $config->{user}; my @rigid = split(',', ($user->{rigid} || "")); @@ -204,19 +205,19 @@ sub user_cgi { # if(lc($config->{iface_mode}) eq "text") { if($title) { - main::graph_header($title, 2); - print(" \n"); - print(" \n"); + push(@output, main::graph_header($title, 2)); + push(@output, " \n"); + push(@output, " \n"); } my (undef, undef, undef, $data) = RRDs::fetch("$rrd", "--start=-$tf->{nwhen}$tf->{twhen}", "AVERAGE", "-r $tf->{res}"); $err = RRDs::error; - print("ERROR: while fetching $rrd: $err\n") if $err; - print("
\n");
-		print("Time    Logged In     Samba  Netatalk\n");
-		print("------------------------------------- \n");
+		push(@output, "ERROR: while fetching $rrd: $err\n") if $err;
+		push(@output, "    
\n");
+		push(@output, "Time    Logged In     Samba  Netatalk\n");
+		push(@output, "------------------------------------- \n");
 		my $line;
 		my @row;
 		my $time;
@@ -225,16 +226,16 @@ sub user_cgi {
 			my ($sys, $smb, $mac) = @$line;
 			@row = ($sys, $smb, $mac);
 			$time = $time - (1 / $tf->{ts});
-			printf(" %2d$tf->{tc}       %6d    %6d    %6d\n", $time, @row);
+			push(@output, sprintf(" %2d$tf->{tc}       %6d    %6d    %6d\n", $time, @row));
 		}
-		print("    
\n"); + push(@output, "
\n"); if($title) { - print(" \n"); - print(" \n"); - main::graph_footer(); + push(@output, " \n"); + push(@output, " \n"); + push(@output, main::graph_footer()); } - print("
\n"); - return; + push(@output, "
\n"); + return @output; } @@ -265,12 +266,12 @@ sub user_cgi { } if($title) { - main::graph_header($title, 2); + push(@output, main::graph_header($title, 2)); } @riglim = @{setup_riglim($rigid[0], $limit[0])}; if($title) { - print(" \n"); - print(" \n"); + push(@output, " \n"); + push(@output, " \n"); } push(@tmp, "AREA:sys#44EE44:Logged In"); push(@tmp, "GPRINT:sys:LAST: Current\\: %3.0lf"); @@ -311,7 +312,7 @@ sub user_cgi { "COMMENT: \\n", "COMMENT: \\n"); $err = RRDs::error; - print("ERROR: while graphing $IMG_DIR" . "$IMG1: $err\n") if $err; + push(@output, "ERROR: while graphing $IMG_DIR" . "$IMG1: $err\n") if $err; if(lc($config->{enable_zoom}) eq "y") { ($width, $height) = split('x', $config->{graph_size}->{zoom}); $picz = $rrd{$version}->("$IMG_DIR" . "$IMG1z", @@ -330,12 +331,12 @@ sub user_cgi { @CDEF, @tmpz); $err = RRDs::error; - print("ERROR: while graphing $IMG_DIR" . "$IMG1z: $err\n") if $err; + push(@output, "ERROR: while graphing $IMG_DIR" . "$IMG1z: $err\n") if $err; } if($title || ($silent =~ /imagetag/ && $graph =~ /user1/)) { if(lc($config->{enable_zoom}) eq "y") { if(lc($config->{disable_javascript_void}) eq "y") { - print(" {url} . "/" . $config->{imgs_dir} . $IMG1z . "\">\n"); + push(@output, " {url} . "/" . $config->{imgs_dir} . $IMG1z . "\">\n"); } else { if($version eq "new") { $picz_width = $picz->{image_width} * $config->{global_zoom}; @@ -344,16 +345,16 @@ sub user_cgi { $picz_width = $width + 115; $picz_height = $height + 100; } - print(" {url} . "/" . $config->{imgs_dir} . $IMG1z . "','','width=" . $picz_width . ",height=" . $picz_height . ",scrollbars=0,resizable=0'))\">\n"); + push(@output, " {url} . "/" . $config->{imgs_dir} . $IMG1z . "','','width=" . $picz_width . ",height=" . $picz_height . ",scrollbars=0,resizable=0'))\">\n"); } } else { - print(" \n"); + push(@output, " \n"); } } if($title) { - print(" \n"); - print(" \n"); + push(@output, " \n"); + push(@output, " \n"); } @riglim = @{setup_riglim($rigid[1], $limit[1])}; undef(@tmp); @@ -395,7 +396,7 @@ sub user_cgi { @CDEF, @tmp); $err = RRDs::error; - print("ERROR: while graphing $IMG_DIR" . "$IMG2: $err\n") if $err; + push(@output, "ERROR: while graphing $IMG_DIR" . "$IMG2: $err\n") if $err; if(lc($config->{enable_zoom}) eq "y") { ($width, $height) = split('x', $config->{graph_size}->{zoom}); $picz = $rrd{$version}->("$IMG_DIR" . "$IMG2z", @@ -415,12 +416,12 @@ sub user_cgi { @CDEF, @tmpz); $err = RRDs::error; - print("ERROR: while graphing $IMG_DIR" . "$IMG2z: $err\n") if $err; + push(@output, "ERROR: while graphing $IMG_DIR" . "$IMG2z: $err\n") if $err; } if($title || ($silent =~ /imagetag/ && $graph =~ /user2/)) { if(lc($config->{enable_zoom}) eq "y") { if(lc($config->{disable_javascript_void}) eq "y") { - print(" {url} . "/" . $config->{imgs_dir} . $IMG2z . "\">\n"); + push(@output, " {url} . "/" . $config->{imgs_dir} . $IMG2z . "\">\n"); } else { if($version eq "new") { $picz_width = $picz->{image_width} * $config->{global_zoom}; @@ -429,10 +430,10 @@ sub user_cgi { $picz_width = $width + 115; $picz_height = $height + 100; } - print(" {url} . "/" . $config->{imgs_dir} . $IMG2z . "','','width=" . $picz_width . ",height=" . $picz_height . ",scrollbars=0,resizable=0'))\">\n"); + push(@output, " {url} . "/" . $config->{imgs_dir} . $IMG2z . "','','width=" . $picz_width . ",height=" . $picz_height . ",scrollbars=0,resizable=0'))\">\n"); } } else { - print(" \n"); + push(@output, " \n"); } } @@ -476,7 +477,7 @@ sub user_cgi { @CDEF, @tmp); $err = RRDs::error; - print("ERROR: while graphing $IMG_DIR" . "$IMG3: $err\n") if $err; + push(@output, "ERROR: while graphing $IMG_DIR" . "$IMG3: $err\n") if $err; if(lc($config->{enable_zoom}) eq "y") { ($width, $height) = split('x', $config->{graph_size}->{zoom}); $picz = $rrd{$version}->("$IMG_DIR" . "$IMG3z", @@ -496,12 +497,12 @@ sub user_cgi { @CDEF, @tmpz); $err = RRDs::error; - print("ERROR: while graphing $IMG_DIR" . "$IMG3z: $err\n") if $err; + push(@output, "ERROR: while graphing $IMG_DIR" . "$IMG3z: $err\n") if $err; } if($title || ($silent =~ /imagetag/ && $graph =~ /user3/)) { if(lc($config->{enable_zoom}) eq "y") { if(lc($config->{disable_javascript_void}) eq "y") { - print(" {url} . "/" . $config->{imgs_dir} . $IMG3z . "\">\n"); + push(@output, " {url} . "/" . $config->{imgs_dir} . $IMG3z . "\">\n"); } else { if($version eq "new") { $picz_width = $picz->{image_width} * $config->{global_zoom}; @@ -510,20 +511,20 @@ sub user_cgi { $picz_width = $width + 115; $picz_height = $height + 100; } - print(" {url} . "/" . $config->{imgs_dir} . $IMG3z . "','','width=" . $picz_width . ",height=" . $picz_height . ",scrollbars=0,resizable=0'))\">\n"); + push(@output, " {url} . "/" . $config->{imgs_dir} . $IMG3z . "','','width=" . $picz_width . ",height=" . $picz_height . ",scrollbars=0,resizable=0'))\">\n"); } } else { - print(" \n"); + push(@output, " \n"); } } if($title) { - print(" \n"); - print(" \n"); - main::graph_footer(); + push(@output, " \n"); + push(@output, " \n"); + push(@output, main::graph_footer()); } - print("
\n"); - return; + push(@output, "
\n"); + return @output; } 1;