From e40b1ff16650e7e8f83419852cbaa8983b5ad07e Mon Sep 17 00:00:00 2001 From: NewKidOnTheBlock Date: Tue, 17 Jan 2023 15:43:40 +0100 Subject: [PATCH] Miscellaneous typo fixes Co-Authored-By: isaak654 --- CHANGELOG.md | 34 +++++++++++++++--------------- SandboxiePlus/QSbieAPI/SbieAPI.cpp | 12 +++++------ 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4a1d15ae..39ff79e5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,21 +5,21 @@ This project adheres to [Semantic Versioning](http://semver.org/). -## [1.6.6 / 5.61.6] - 2023-01-? +## [1.6.6 / 5.61.6] - 2023-01-16 ### Changed -- reworked trace log retrival to greately improving performance +- reworked trace log retrieval for vastly improved performance - improved list/tree finder - improved trace logging -- enabled drop admin rights option for compartment style boxes --- Note: programs started unsandboxed can not have rights dropped, but UAC prompts and elevation from within the sandboxed are blocked +- enabled drop admin rights option for compartment boxes +-- Note: programs started unsandboxed can not have rights dropped, but UAC prompts and elevation attempts from within the sandbox are blocked ### Fixed - fixed potential BSOD issue in the driver -- fixed crash in in trace log [#2599](https://github.com/sandboxie-plus/Sandboxie/issues/2599) -- fixed tray issue [2600](https://github.com/sandboxie-plus/Sandboxie/pull/2600) (okrc) -- fidex issues with shortcuts [#2601](https://github.com/sandboxie-plus/Sandboxie/pull/2601) (okrc) +- fixed crash in the trace log [#2599](https://github.com/sandboxie-plus/Sandboxie/issues/2599) +- fixed tray issue [#2600](https://github.com/sandboxie-plus/Sandboxie/pull/2600) (okrc) +- fixed issues with shortcuts [#2601](https://github.com/sandboxie-plus/Sandboxie/pull/2601) (okrc) @@ -29,10 +29,10 @@ This project adheres to [Semantic Versioning](http://semver.org/). ## [1.6.5 / 5.61.5] - 2023-01-10 ### Added -- added user mode syscall tracing, now system calls can be logged also in compartment type boxes as well as all Win32k syscalls +- added user mode system call tracing, now syscalls can be logged in compartment boxes as well as all Win32k syscalls ### Changed -- reworked trace log model, now it can load over 10e6 entries in under 1 second +- reworked trace log model, now it can load more than a million entries in less than one second - ApiLog support is now hidden from the trace UI when the appropriate DLLs are missing ### Fixed @@ -50,10 +50,10 @@ This project adheres to [Semantic Versioning](http://semver.org/). - added contribution guidelines in the Help menu for both Plus and Classic UIs [#2551](https://github.com/sandboxie-plus/Sandboxie/pull/2551) ### Fixed -- fixed issue with auto delete sandbox on SandMan startup [#2555](https://github.com/sandboxie-plus/Sandboxie/issues/2555) +- fixed issue with auto-delete sandbox on SandMan startup [#2555](https://github.com/sandboxie-plus/Sandboxie/issues/2555) - fixed issue with Windows 11 context menu when SandMan was not already running [#2284](https://github.com/sandboxie-plus/Sandboxie/issues/2284) - fixed issue with the display about cmbDefault [#2560](https://github.com/sandboxie-plus/Sandboxie/pull/2560) (okrc) -- fixed issue with color inaccuracy [#2570](https://github.com/sandboxie-plus/Sandboxie/pull/2570) (okrc) +- fixed issue with colour inaccuracy [#2570](https://github.com/sandboxie-plus/Sandboxie/pull/2570) (okrc) - fixed issue with Templates.ini loading on first start [#2574](https://github.com/sandboxie-plus/Sandboxie/issues/2574) - fixed Cyberpunk 2077 not being able to load mods when sandboxed - fixed performance issue in games @@ -373,7 +373,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). ### Added - added icons to sub tabs in the box options dialog - recovery and message pop-up menu options are not persisting across UI restarts any more -- added new box color, a white box indicates that its not really a sandbox and is displayed when the user specified OpenFilePath=* or alike +- added new box colour, a white box indicates that it's not really a sandbox and is displayed when the user specified OpenFilePath=* or alike ### Changed - Sandboxie no longer issues message 1301 when forced processes are temporarily disabled @@ -996,7 +996,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). ### Added - replaced "Open with" with a Sandboxie dialog to work on Windows 10 [#1138](https://github.com/sandboxie-plus/Sandboxie/issues/1138) -- added ability to run Win32 store apps in App Compartment mode (on Windows 11 requires COM to be open) +- added ability to run Win32 store apps in app compartment mode (requires COM to be open in Windows 11) -- Note: this does not mean UWP store apps, just regular Win32 apps packaged to be deployed via the store - added new debug options "UnstrippedToken=y" and "KeepUserGroup=y" - added double-click to recover files and folders in recovery window [#1466](https://github.com/sandboxie-plus/Sandboxie/issues/1466) @@ -1066,7 +1066,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). - "EnableWin32kHooks=y" is now enabled by default, as no issues were reported in 1.0.3 -- Note: currently only the GdiDdDDI* hooks are applied, required for Chromium HW acceleration - cleaned up low-level hooking code -- "RunRpcssAsSystem=y" is now auto applied for boxes in "App Compartment" mode when "RunServicesAsSystem=y" or "MsiInstallerExemptions=y" are present +- "RunRpcssAsSystem=y" is now auto applied for boxes in app compartment mode when "RunServicesAsSystem=y" or "MsiInstallerExemptions=y" are present ### Fixed - fixed RPC handling in case a requested open service is not running [#1443](https://github.com/sandboxie-plus/Sandboxie/issues/1443) @@ -1130,15 +1130,15 @@ This project adheres to [Semantic Versioning](http://semver.org/). -- all locations except generic Windows system paths will need to be opened explicitly for read and/or write access -- using "NormalFilePath=...", "NormalKeyPath=...", "NormalIpcPath=..." allows to open locations to be readable and sandboxed -- added new "App Compartment" mode of operation, it is enabled by adding "NoSecurityIsolation=y" to the box configuration +- added new app compartment mode of operation, it is enabled by adding "NoSecurityIsolation=y" to the box config -- in this mode, security is traded in for compatibility, it should not be used for untrusted applications -- Note: in this mode, file and registry filtering are still in place, hence processes run without administrative privileges -- it is reasonably safe, all filtering can be disabled with "NoSecurityFiltering=y" - added experimental use of ObRegisterCallbacks to filter object creation and duplication --- this filtering is independent from the regular SbieDrv's syscall-based filtering, hence it also applies to App Compartments +-- this filtering is independent from the regular SbieDrv's syscall-based filtering, hence it also applies to app compartments -- with it enabled, an application running in a compartment will not be able to manipulate processes running outside the sandbox --- Note: this feature improves the security of non-isolated App Compartment boxes +-- Note: this feature improves the security of non-isolated app compartment boxes -- to enable this feature, set "EnableObjectFiltering=y" in the global section and reload the driver -- when globally activated, the filtering can be disabled for individual boxes with "DisableObjectFilter=y" diff --git a/SandboxiePlus/QSbieAPI/SbieAPI.cpp b/SandboxiePlus/QSbieAPI/SbieAPI.cpp index f527eecb..4079e9d7 100644 --- a/SandboxiePlus/QSbieAPI/SbieAPI.cpp +++ b/SandboxiePlus/QSbieAPI/SbieAPI.cpp @@ -295,7 +295,7 @@ SB_STATUS CSbieAPI::Connect(bool takeOver, bool withQueue) m->lastMessageNum = 0; //m->lastRecordNum = 0; - // Note: this lib is not using all functions hence it can be compatible with multiple driver ABI revisions + // Note: this lib is not using all functions, hence it can be compatible with multiple driver ABI revisions //QStringList CompatVersions = QStringList () << "5.55.0"; //QString CurVersion = GetVersion(); //if (!CompatVersions.contains(CurVersion)) @@ -349,7 +349,7 @@ SB_STATUS CSbieAPI::Disconnect() m->SbieApiHandle = INVALID_HANDLE_VALUE; } - // ensure the client thread is enteirly terminated to avoid the service keeping the reference + // ensure that the client thread is entirely terminated to avoid the service keeping the reference // see SbieSvc PortDisconnectByCreateTime QThread::msleep(250); if (m->PortHandle) { @@ -480,7 +480,7 @@ SB_STATUS CSbieAPI__CallServer(SSbieAPI* m, MSG_HEADER* req, MSG_HEADER** prpl) if (ResData[3] != CurSeqNumber) return SB_ERR(SB_ServiceFail, QVariantList() << QString("mismatched reply")); // 2203 - // clear highest byte of the size filed + // clear highest byte of the size field ResData[3] = 0; BuffLen = ((MSG_HEADER*)ResData)->length; } @@ -2372,7 +2372,7 @@ bool CSbieAPI::GetLog() /* QString Message = CSbieAPI__FormatSbieMsg(m, MsgCode, str1, str2); - if (ProcessId != 4) // if its not from the driver add the pid + if (ProcessId != 4) // if it is not from the driver, add the pid Message += tr(", by process: %1").arg(ProcessId); emit LogMessage(Message, MessageId); @@ -2516,7 +2516,7 @@ bool CSbieAPI::GetMonitor() if (!NT_SUCCESS(m->IoControl(parms))) return false; // error or no more entries - if (type == 0) // versions prioir to 5.45.0 return success and type 0 when there are no more entries + if (type == 0) // versions prior to 5.45.0 return success and type 0 when there are no more entries return false; //if (RecordNum != m->lastRecordNum + 1 && !m->clearingBuffers) @@ -2540,7 +2540,7 @@ bool CSbieAPI::GetMonitor() return true; -#else // bulk retrival starting with build 1.6.6 +#else // bulk retrieval starting with build 1.6.6 if (m->traceBuffer == NULL) { m->traceBufferLen = 256 * PAGE_SIZE;