From 18f47be237cc7cb9fc48b8c35b65c5bdd0f9aa90 Mon Sep 17 00:00:00 2001 From: andrethomas Date: Tue, 14 Aug 2018 21:36:10 +0200 Subject: [PATCH] Cleanup #else and #endif statements with // USE_MCP230xx_OUTPUT comments --- sonoff/xsns_29_mcp230xx.ino | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/sonoff/xsns_29_mcp230xx.ino b/sonoff/xsns_29_mcp230xx.ino index 5de0febb0..9d4ab89fc 100644 --- a/sonoff/xsns_29_mcp230xx.ino +++ b/sonoff/xsns_29_mcp230xx.ino @@ -60,7 +60,7 @@ uint8_t mcp230xx_int_en = 0; #ifdef USE_MCP230xx_OUTPUT uint16_t mcp230xx_tele_count = 0; -#endif +#endif // USE_MCP230xx_OUTPUT const char MCP230XX_SENSOR_RESPONSE[] PROGMEM = "{\"Sensor29_D%i\":{\"MODE\":%i,\"PULL-UP\":\"%s\",\"STATE\":\"%s\"}}"; @@ -103,7 +103,7 @@ void MCP230xx_ApplySettings(void) { uint8_t reg_iodir = 0xFF; #ifdef USE_MCP230xx_OUTPUT uint8_t reg_portpins = 0x00; -#endif +#endif USE_MCP230xx_OUTPUT for (uint8_t idx = 0; idx < 8; idx++) { switch (Settings.mcp230xx_config[idx+(mcp230xx_port*8)].pinmode) { case 0 ... 1: @@ -133,18 +133,18 @@ void MCP230xx_ApplySettings(void) { if (Settings.mcp230xx_config[idx+(mcp230xx_port*8)].pullup && (Settings.mcp230xx_config[idx+(mcp230xx_port*8)].pinmode < 5)) { reg_gppu |= (1 << idx); } -#else +#else // not USE_MCP230xx_OUTPUT if (Settings.mcp230xx_config[idx+(mcp230xx_port*8)].pullup) { reg_gppu |= (1 << idx); } -#endif +#endif // USE_MCP230xx_OUTPUT } I2cWrite8(mcp230xx_address, MCP230xx_GPPU+mcp230xx_port, reg_gppu); I2cWrite8(mcp230xx_address, MCP230xx_GPINTEN+mcp230xx_port, reg_gpinten); I2cWrite8(mcp230xx_address, MCP230xx_IODIR+mcp230xx_port, reg_iodir); #ifdef USE_MCP230xx_OUTPUT I2cWrite8(mcp230xx_address, MCP230xx_GPIO+mcp230xx_port, reg_portpins); -#endif +#endif // USE_MCP230xx_OUTPUT } mcp230xx_int_en=int_en; } @@ -306,7 +306,7 @@ bool MCP230xx_Command(void) { if (data == "RESET4") { MCP230xx_Reset(4); return serviced; } #ifdef USE_MCP230xx_OUTPUT if (data == "RESET5") { MCP230xx_Reset(5); return serviced; } -#endif +#endif // USE_MCP230xx_OUTPUT _a = data.indexOf(","); pin = data.substring(0, _a).toInt(); if (pin < mcp230xx_pincount) { @@ -321,7 +321,7 @@ bool MCP230xx_Command(void) { uint8_t pinmod = Settings.mcp230xx_config[pin].pinmode; sprintf(pinstatustxtr,ConvertNumTxt(portdata>>(pin-(port*8))&1,pinmod)); snprintf_P(mqtt_data, sizeof(mqtt_data), MCP230XX_SENSOR_RESPONSE,pin,pinmod,pulluptxtr,pinstatustxtr); -#else +#else // not USE_MCP230xx_OUTPUT sprintf(pinstatustxtr,ConvertNumTxt(portdata>>(pin-(port*8))&1)); snprintf_P(mqtt_data, sizeof(mqtt_data), MCP230XX_SENSOR_RESPONSE,pin,Settings.mcp230xx_config[pin].pinmode,pulluptxtr,pinstatustxtr); #endif //USE_MCP230xx_OUTPUT @@ -431,7 +431,7 @@ void MCP230xx_OutputTelemetry(void) { } } -#endif +#endif // USE_MCP230xx_OUTPUT /*********************************************************************************************\ @@ -452,7 +452,7 @@ boolean Xsns29(byte function) mcp230xx_tele_count=0; MCP230xx_OutputTelemetry(); } -#endif +#endif // USE_MCP230xx_OUTPUT break; case FUNC_EVERY_50_MSECOND: if (mcp230xx_int_en) { // Only check for interrupts if its enabled on one of the pins