From fccf17521aeec7438785a132434137f266474119 Mon Sep 17 00:00:00 2001 From: Tom Collins Date: Mon, 9 Mar 2020 11:39:44 -0700 Subject: [PATCH] py/objstr: Remove duplicate % in error string. The double-% was added in 11de8399fe5f9ef54589b14470faf8d4fcc5ccaa (Jun 2014) when such errors were formatted with printf. But then 55830dd9bf4fee87c0a6d3f38c51614fea0eb483 (Dec 2018) changed mp_obj_new_exception_msg() to not format the message, as discussed in #3004. So such error strings are no longer formatted and a % is just that. --- py/objstr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/py/objstr.c b/py/objstr.c index aba03491db..aa35d84a8e 100644 --- a/py/objstr.c +++ b/py/objstr.c @@ -1523,7 +1523,7 @@ STATIC mp_obj_t str_modulo_format(mp_obj_t pattern, size_t n_args, const mp_obj_ size_t slen; const char *s = mp_obj_str_get_data(arg, &slen); if (slen != 1) { - mp_raise_TypeError("%%c needs int or char"); + mp_raise_TypeError("%c needs int or char"); } mp_print_strn(&print, s, 1, flags, ' ', width); } else if (arg_looks_integer(arg)) {