From 275cb370310dfb2f8d17d8d32c6a0b101295daba Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Fri, 4 Jun 2021 14:52:36 -0700 Subject: [PATCH] comments --- net/uring/io_uring_linux.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/uring/io_uring_linux.go b/net/uring/io_uring_linux.go index 391b5841d..4f26b2170 100644 --- a/net/uring/io_uring_linux.go +++ b/net/uring/io_uring_linux.go @@ -142,6 +142,7 @@ func (u *UDPConn) ReadFromNetaddr(buf []byte) (int, netaddr.IPPort, error) { rbuf := sliceOf(r.buf, n) copy(buf, rbuf) // Queue up a new request. + // TODO: Do this in a goroutine? err = u.submitRecvRequest(int(idx)) if err != nil { panic("how should we handle this?") @@ -229,7 +230,6 @@ func (u *UDPConn) WriteTo(p []byte, addr net.Addr) (n int, err error) { C.setIP(&r.sa, C.uint32_t(ip)) C.setPort(&r.sa, C.uint16_t(udpAddr.Port)) - // TODO: populate r.sa with ip/port C.submit_sendmsg_request( u.sendRing, // ring r,