From 60c00605d3061cff20f0d33bd677a86498021e7d Mon Sep 17 00:00:00 2001 From: Avery Pennarun Date: Thu, 30 Jul 2020 04:36:06 -0400 Subject: [PATCH] ipn/setClientStatus: fix inverted prefsChanged check. We need to emit Prefs when it *has* changed, not when it hasn't. Test is added in our e2e test, separately. Fixes: #620 Signed-off-by: Avery Pennarun --- ipn/local.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipn/local.go b/ipn/local.go index d7b806e89..20ac40125 100644 --- a/ipn/local.go +++ b/ipn/local.go @@ -209,7 +209,7 @@ func (b *LocalBackend) setClientStatus(st controlclient.Status) { interact := b.interact if st.Persist != nil { - if b.prefs.Persist.Equals(st.Persist) { + if !b.prefs.Persist.Equals(st.Persist) { prefsChanged = true b.prefs.Persist = st.Persist.Clone() }