From 9ff5b380cb94d131f56c85bb10cf21ba04dd81e9 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Wed, 29 Jul 2020 15:15:05 -0700 Subject: [PATCH] ipn/ipnserver: staticcheck is not wrong shamecube.gif --- ipn/ipnserver/server.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ipn/ipnserver/server.go b/ipn/ipnserver/server.go index 4dacc77c7..56c59da34 100644 --- a/ipn/ipnserver/server.go +++ b/ipn/ipnserver/server.go @@ -188,7 +188,6 @@ func Run(ctx context.Context, logf logger.Logf, logid string, getEngine func() ( continue } logf("%d: trying getEngine again...", i) - //lint:ignore SA4006 staticcheck is wrong eng, err = getEngine() if err == nil { logf("%d: GetEngine worked; exiting failure loop", i) @@ -204,7 +203,9 @@ func Run(ctx context.Context, logf logger.Logf, logid string, getEngine func() ( s.Read(make([]byte, 1)) }() } - return ctx.Err() + if err := ctx.Err(); err != nil { + return err + } } var store ipn.StateStore