From f0ee03dfafda9c5a8804b25f20ea881090bd4ab5 Mon Sep 17 00:00:00 2001 From: Sonia Appasamy Date: Mon, 15 May 2023 23:34:55 -0400 Subject: [PATCH] cmd/tailscale/cli: [serve] add reset flag Usage: `tailscale serve reset` Fixes #8139 Signed-off-by: Sonia Appasamy --- cmd/tailscale/cli/serve.go | 20 ++++++++++++++++++++ cmd/tailscale/cli/serve_test.go | 5 ++++- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/cmd/tailscale/cli/serve.go b/cmd/tailscale/cli/serve.go index 59518fecc..3921a57a0 100644 --- a/cmd/tailscale/cli/serve.go +++ b/cmd/tailscale/cli/serve.go @@ -40,6 +40,7 @@ serve https: [off] serve tcp: tcp://localhost: [off] serve tls-terminated-tcp: tcp://localhost: [off] serve status [--json] + serve reset `), LongHelp: strings.TrimSpace(` *** BETA; all of this is subject to change *** @@ -87,6 +88,13 @@ EXAMPLES }), UsageFunc: usageFunc, }, + { + Name: "reset", + Exec: e.runServeReset, + ShortHelp: "reset current serve/funnel config", + FlagSet: e.newFlags("serve-reset", nil), + UsageFunc: usageFunc, + }, }, } } @@ -705,3 +713,15 @@ func elipticallyTruncate(s string, max int) string { } return s[:max-3] + "..." } + +// runServeReset clears out the current serve config. +// +// Usage: +// - tailscale serve reset +func (e *serveEnv) runServeReset(ctx context.Context, args []string) error { + if len(args) != 0 { + return flag.ErrHelp + } + sc := new(ipn.ServeConfig) + return e.lc.SetServeConfig(ctx, sc) +} diff --git a/cmd/tailscale/cli/serve_test.go b/cmd/tailscale/cli/serve_test.go index 8031b2b02..2dec06dd7 100644 --- a/cmd/tailscale/cli/serve_test.go +++ b/cmd/tailscale/cli/serve_test.go @@ -224,7 +224,10 @@ func TestServeConfigMutations(t *testing.T) { command: cmd("https:443 bar https://127.0.0.1:8443"), want: nil, // nothing to save }) - add(step{reset: true}) + add(step{ // try resetting using reset command + command: cmd("reset"), + want: &ipn.ServeConfig{}, + }) add(step{ command: cmd("https:443 / https+insecure://127.0.0.1:3001"), want: &ipn.ServeConfig{