all: imp code

internal/aghnet/hostgen.go

@@ -22,14 +22,11 @@ func GenerateHostname(ip netip.Addr) (hostname string) {
 	}
 
 	ip = ip.Unmap()
+	hostname = ip.StringExpanded()
 
 	if ip.Is4() {
-		hostname = ip.String()
-
 		return strings.Replace(hostname, ".", "-", -1)
 	}
 
-	hostname = ip.StringExpanded()
-
 	return strings.Replace(hostname, ":", "-", -1)
 }

internal/aghnet/hostgen_test.go

@@ -36,18 +36,6 @@ func TestGenerateHostName(t *testing.T) {
 	})
 
 	t.Run("invalid", func(t *testing.T) {
-		testCases := []struct {
+		assert.Panics(t, func() { GenerateHostname(netip.Addr{}) })
-			name string
-			ip   netip.Addr
-		}{{
-			name: "nil",
-			ip:   netip.Addr{},
-		}}
-
-		for _, tc := range testCases {
-			t.Run(tc.name, func(t *testing.T) {
-				assert.Panics(t, func() { GenerateHostname(tc.ip) })
-			})
-		}
 	})
 }

internal/dhcpd/v6_unix.go

@@ -309,9 +309,7 @@ func (s *v6Server) reserveLease(mac net.HardwareAddr) *Lease {
 	s.leasesLock.Lock()
 	defer s.leasesLock.Unlock()
 
-	var ip net.IP
+	ip := s.findFreeIP()
-	copy(ip, s.conf.ipStart)
-	ip = s.findFreeIP()
 	if ip == nil {
 		i := s.findExpiredLease()
 		if i < 0 {