Pull request 1804: newline-lint

Merge in DNS/adguard-home from newline-lint to master

Squashed commit of the following:

commit 2fc0b662b9ac9d954275c5ebe8c140be4cd365be
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Apr 6 14:16:14 2023 +0300

    client: rm line

commit 10246727179a84094edd17fad5cd6f0a5c38b821
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Apr 6 13:51:06 2023 +0300

    all: add newline lint

client/src/helpers/trackers/trackers.json

@@ -1,5 +1,5 @@
 {
-    "timeUpdated": "2023-03-29T00:10:35.167Z",
+    "timeUpdated": "2023-04-06T10:46:09.881Z",
     "categories": {
         "0": "audio_video_player",
         "1": "comments",

openapi/.gitignore

@@ -1,2 +0,0 @@
-.DS_Store
-node_modules

scripts/hooks/pre-commit

@@ -90,7 +90,7 @@ then
 	make VERBOSE="$verbose" go-os-check go-lint go-test
 fi
 
-if [ "$( git diff --cached --name-only -- '*.md' '*.yaml' '*.yml' )" ]
+if [ "$( git diff --cached --name-only -- '*.md' '*.txt' '*.yaml' '*.yml' )" ]
 then
 	make VERBOSE="$verbose" txt-lint
 fi

scripts/make/txt-lint.sh

@@ -27,6 +27,31 @@ set -f -u
 # Source the common helpers, including not_found.
 . ./scripts/make/helper.sh
 
-git ls-files -- '*.md' '*.yaml' '*.yml' 'client/src/__locales/en.json'\
+# Simple analyzers
+
+# trailing_newlines is a simple check that makes sure that all plain-text files
+# have a trailing newlines to make sure that all tools work correctly with them.
+#
+# TODO(a.garipov): Add to the standard skeleton project.
+trailing_newlines() {
+	nl="$( printf "\n" )"
+	readonly nl
+
+	git ls-files\
+		':!*.png'\
+		':!*.tar.gz'\
+		':!*.zip'\
+		| while read -r f
+		do
+			if [ "$( tail -c -1 "$f" )" != "$nl" ]
+			then
+				printf '%s: must have a trailing newline\n' "$f"
+			fi
+		done
+}
+
+run_linter -e trailing_newlines
+
+git ls-files -- '*.md' '*.txt' '*.yaml' '*.yml' 'client/src/__locales/en.json'\
 	| xargs misspell --error\
 	| sed -e 's/^/misspell: /'

scripts/querylog/.gitignore

@@ -1,2 +0,0 @@
-node_modules
-test/anonquerylog.json

scripts/querylog/anonymize.js

@@ -116,4 +116,3 @@ const main = async () => {
 }
 
 main();
-