Commit Graph

578 Commits

Author SHA1 Message Date
Sebastián Mestre 57c7f5f61f Isobuffer refactor - part 2 (#65)
* Split isoBuffer::maybeOutputSampleToFile into two functions

* reorder isoBuffer data members. clean up comments and formatting. clean isoBuffer::writeBuffer

* Remove my name from a comment

* Use type-safe Qt connect. Move comments. change IO column comparison.

* Give isoBuffer the proper ringBuffer behaviour

* Change the behaviour of isoBuffer::readBuffer; Change comments to reflect this.

* Fix a silly mistake in isobuffer.cpp (compiler warnings are awesome)

* Modify isoBuffer::readBuffer

* add destructor to isoBuffer, reorder initializer list. isobuffer.cpp now compiles with no warnings.

* Change isoBuffer::m_buffer to be a unique_ptr

* Change isoBuffer::m_stopDecoding to isoBuffer::m_isDecoding

* Refactor isoBuffer::readBuffer to use unique_ptr. Currently a memory leak

* Change signature of isoBuffer::readBuffer to return unique_ptr. adapt isoDriver acordingly.

* Clean up comments on isobuffer .h and .cpp

* Incorporate review comments: formatting, explicit unique_ptr, spelling
2019-01-28 11:14:04 +11:00
Chris Esposito 31f68faf4e
Update isobuffer.h 2019-01-23 16:14:24 +11:00
Sebastián Mestre 015d41624d Isobuffer refactor (#64)
* make isobuffer.cpp follow the common bracket style

* Add a few utility functions to isoBuffer, and reorganize and comment isobuffer.h

* refactor a few functions in isoBuffer using the newly added functions

* Clean up isoBuffer::readBuffer. Requires particular attention during review

* remove unused variable isoBuffer::firstTime

* Fix formatting and add a comment to isoBuffer::maybeOutputSampleToFile

* move invariant out of loop in isoBuffer::writeBuffer_short

* Substantially refactor isoBuffer::readBuffer

* change spaces to tabs on isoBuffer.h

* spaces to tabs on isobuffer.cpp and isobuffer.h, but properly

* Enforce const correctness on some methods of isoBuffer

* Add some comments to isobuffer.cpp

* Remove duplication in isoBuffer::cap_xnfromxxx functions by extracting common functionality to a free function

* Format isobuffer.h and isobuffer.cpp

* add inserted count to isoBuffer

* further modification to isoBuffer::readBuffer

* Correct a comment in isoBuffer::readBuffer

* add an anonymous namespace with file-wide constants

* remove isoBuffer::openFile, and move initialization isoBuffer to initializer list

* add lines between if statements in isoBuffer::insertIntoBuffer

* add spaces after // to some comments

* extract common functionality from writeBuffer_xxx functions to function template

* update header file to reflect previous commits

* make isoBuffer::return nullptr in a troublesome case

* add space after // to some other comments

* Make capSample a member function of isoBuffer, delete a macro in isobuffer.cpp

* clean up various comments and declarations in isobuffer.cpp

* make isoBuffer::gainBuffer work for any gain value

* make enableFileIO use the constant definitions made in a recent commit

* Remove type argument from isoBuffer::serialManage

* make isoBuffer::readBuffer return a zero-filled buffer instead of null

* Remove isoBuffer::glitchInsert

* Add a bunch of TODOs to isobuffer.cpp and isobuffer.h

* Rename member variables of isoBuffer to have an m_ prefix

* Move isoBuffer::capSample comparison functors to anonymous namespace

* Make CONSOLE_UPDATE_TIMER_PERIOD on isobuffer.h a constexpr intead of a macro
2019-01-23 16:13:40 +11:00
Sebastián Mestre 4499db10bf Isobufferbuffer integration (#62)
* Update all code to use the new isoBufferBuffer interface, and remove the old one; also rename isoBufferBuffer::add(uint8_t) to insert_hex

* remove unnecessary include directive from isobuffer.h

* Remove 'Legacy Interface' comment from isoBufferBuffer header and implementation, move insert_hex closer to other insert functions in the header and implementation

* Remove TODO comment of a finished task
2018-12-31 10:02:04 +11:00
Chris Esposito 0e97d4c150
Update .travis.yml 2018-12-28 14:22:21 +11:00
Chris Esposito 81ef2e8e59
Update README.md 2018-12-28 14:17:01 +11:00
Chris Esposito 007c183c9f
MATRIX_EVAL 2018-12-28 14:15:45 +11:00
Chris Esposito 17cbfd29fa
Update .travis.yml 2018-12-28 14:15:02 +11:00
Chris Esposito 35c97d9488
Travis.yml uses aliases rather than CC/CXX 2018-12-28 10:39:59 +11:00
Sebastián Mestre 607734c60d isoBufferBuffer refactor (#61)
* Reimplements isoBufferBuffer and fixes a potential memory leak due to lack of a destructor
2018-12-28 09:51:10 +11:00
Chris Esposito bbc5948fdd
Travis should use gcc-7 on linux 2018-12-28 09:26:49 +11:00
Chris Esposito c91a42d7c4
Update README.md 2018-12-27 11:52:56 +11:00
Chris Esposito 14a5ab67ff
Added C++14 support to qmake file 2018-12-27 11:49:11 +11:00
Chris Esposito 64b8b9311b
Update .travis.yml 2018-12-11 20:38:31 +11:00
Chris Esposito 2b5ce2ecc4 Supports odd and even parity 2018-12-11 20:25:14 +11:00
Chris Esposito eb57b2c327
Update .travis.yml 2018-11-26 15:42:54 +11:00
Chris Esposito aa0ac15e7d
Update .appveyor.yml 2018-11-26 15:14:53 +11:00
Chris Esposito ac1b82e2ab
Update .appveyor.yml 2018-11-26 15:12:12 +11:00
Chris Esposito ffb2714c7b
Copies libusbk to deploy. 2018-11-26 15:02:08 +11:00
Chris Esposito f817437237
Update .appveyor.yml 2018-11-26 14:40:22 +11:00
Chris Esposito ab213cbacd
fixed windeployqt ordering 2018-11-26 14:40:08 +11:00
Chris Esposito 44ae23a2bc
Uses msvc 2015 2018-11-26 14:28:17 +11:00
Chris Esposito 74ac08cfc5
Update .appveyor.yml 2018-11-26 13:11:19 +11:00
Chris Esposito 336484f94f
Update .appveyor.yml 2018-11-26 13:08:54 +11:00
Chris Esposito 3f8879a006
Update .appveyor.yml 2018-11-26 13:01:26 +11:00
Chris Esposito 890639d2f4
Update .appveyor.yml 2018-11-26 12:54:59 +11:00
Chris Esposito b16a1a189a
Update .appveyor.yml 2018-11-26 12:53:31 +11:00
Chris Esposito f1cd606be4
Update .appveyor.yml 2018-11-26 12:39:55 +11:00
Chris Esposito f4682a9ee2
Update .appveyor.yml 2018-11-26 12:13:42 +11:00
Chris Esposito 5b283a1059
Update .appveyor.yml 2018-11-26 12:12:18 +11:00
Chris Esposito fa075eab1e
Update .appveyor.yml 2018-11-26 12:07:28 +11:00
Chris Esposito f1e8519bb8
Update .appveyor.yml 2018-11-26 11:56:49 +11:00
Chris Esposito 1e4d2762fd
Update .appveyor.yml 2018-11-25 15:26:51 +11:00
Chris Esposito f2a25f13ea
Update .appveyor.yml 2018-11-25 15:20:30 +11:00
Chris Esposito b7a44b2a04
Update .appveyor.yml 2018-11-25 15:03:58 +11:00
Chris Esposito 1f54e13724
Update .appveyor.yml 2018-11-25 14:42:58 +11:00
Chris Esposito c1e69e09f5
Update .appveyor.yml 2018-11-25 14:42:06 +11:00
Chris Esposito b33b942352
Update .appveyor.yml 2018-11-25 14:40:08 +11:00
Chris Esposito acfa960883
Update .appveyor.yml 2018-11-25 14:30:12 +11:00
Chris Esposito a021ec93e0
Update .appveyor.yml 2018-11-25 13:47:26 +11:00
Chris Esposito 0b229cb85b
Update .appveyor.yml 2018-11-25 13:31:44 +11:00
Chris Esposito 20d29b77cd
Update .appveyor.yml 2018-11-25 13:12:53 +11:00
Chris Esposito ffa8fd986c
Update .appveyor.yml 2018-11-25 13:08:33 +11:00
Chris Esposito 592b2e5276
Update .appveyor.yml 2018-11-25 13:00:49 +11:00
Chris Esposito c3d1f8abb0
windeployqt to appveyor 2018-11-25 12:56:24 +11:00
Chris Esposito 76b312de8a
Update .appveyor.yml 2018-11-25 12:52:42 +11:00
Chris Esposito 768a8353d7
Update PCB readme to give credit to Ele4nor 2018-11-25 11:10:21 +11:00
Chris Esposito 5019ceb7d8
Merge pull request #59 from Ele4nor/altiumpcb
Altiumpcb
2018-11-25 11:08:42 +11:00
Ele4nor d50f93fa86 Add generated schematic, BOM, gerber & NC Drill files 2018-11-22 05:32:30 -08:00
Chris Esposito 8372faa027 yml env 2018-11-22 20:27:49 +11:00