mirrors
/
Monitorix
mirror of https://github.com/mikaku/Monitorix.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

new optional https_url config value 

Hey,
I am suggesting a simple config addition.

When I started using https on my nginx, I decided to let Monitorix bind on 127.0.0.1 and use nginx as reverse-proxy. That worked fine, but Monitorix cgi kept using http:// scheme for its urls ($config{url} variable all over the Monitorix) which makes sense as it don't know I am proxying http requests which are https when looking at it from the outside world.

To illustrate - here is my setup:
BROWSER <-https-> NGINX (0.0.0.0) <-http-> MONITORIX (127.0.0.1)

This way I can protect monitorix and other similar locally-listening servers via nginx auth and https transfer.

The proposed change adds a new optional variable https_url which can be added to Monitorix confix file. When it's https_url = y, Monitorix will use https:// scheme for all links even when the internal monitorix server is listening for HTTP requests. All existing functionality for HTTPS CGI detection etc remains. I have tested all three cases (https_url se to y, to n and not set). Worked fine.

Cheers,
Mario
This commit is contained in:
K3A 2013-11-24 15:38:28 +01:00
parent 1bbb460149
commit a65d12c40f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
monitorix.cgi
View File

@ -215,7 +215,7 @@ my $conf = new Config::General(
);
%config = $conf->getall;
$config{url} = $ENV{HTTPS} ? "https://" . $ENV{HTTP_HOST} : "http://" . $ENV{HTTP_HOST};
$config{url} = ($ENV{HTTPS} || $config{https_url} eq "y") ? "https://" . $ENV{HTTP_HOST} : "http://" . $ENV{HTTP_HOST};
$config{hostname} = $config{hostname} || $ENV{SERVER_NAME};
if(!($config{hostname})) { # called from the command line
$config{hostname} = "127.0.0.1";