mirrors/PCUGameManager
mirrors
/
PCUGameManager
mirror of https://github.com/lantzelot-swe/PCUGameManager.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: validation of url

This commit is contained in:
lantzelot-swe 2021-01-14 23:02:55 +01:00
parent 28c24ba9d5
commit 6cc01f9968
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/main/java/se/lantz/scraper/C64comScraper.java
View File

@ -68,7 +68,7 @@ public class C64comScraper implements Scraper
public void connect(String url) throws IOException
{
this.c64comGameUrl = "";
//c64.com gives no errors for invalid urls. Check if there is an title to make sure it's valid
//c64.com gives no errors for invalid urls. Check if there is an non-empty title to make sure it's valid
Connection.Response result = Jsoup.connect(url).method(Connection.Method.GET).execute();
Document doc = result.parse();
//Fetch right frame
@ -76,12 +76,9 @@ public class C64comScraper implements Scraper
//Fetch title
Elements queryElements = mainFrameDocument.select(titleCssQuery);
Element first = queryElements.first();
if (first != null)
if (first == null || first.text().isEmpty())
{
if (first.text().isEmpty())
{
throw new IllegalArgumentException();
}
throw new IllegalArgumentException();
}
this.c64comGameUrl = url;