mirrors
/
PretendYoureXyzzy
mirror of https://github.com/ajanata/PretendYoureXyzzy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

make metrics methods agree in tense

This commit is contained in:
Andy Janata 2017-02-23 22:36:58 -08:00
parent 45690c1914
commit a0d21cd2fd
5 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/net/socialgamer/cah/StartupUtils.java
View File

@ -135,7 +135,7 @@ public class StartupUtils extends GuiceServletContextListener {
CardcastService.hackSslVerifier();
// log that the server (re-)started to metrics logging (to flush all old games and users)
injector.getInstance(Metrics.class).serverStarted(
injector.getInstance(Metrics.class).serverStart(
injector.getInstance(Key.get(String.class, UniqueId.class)));
}

2
src/main/java/net/socialgamer/cah/data/Game.java
View File

@ -1512,7 +1512,7 @@ public class Game {
rescheduleTimer(task, ROUND_INTERMISSION);
}
metrics.roundJudged(currentUniqueId, user.getSessionId(), cardPlayer.getUser().getSessionId(),
metrics.roundComplete(currentUniqueId, user.getSessionId(), cardPlayer.getUser().getSessionId(),
playedCards.cardsByUser());
return null;

4
src/main/java/net/socialgamer/cah/metrics/KafkaMetrics.java
View File

@ -48,7 +48,7 @@ public class KafkaMetrics implements Metrics {
private static final Logger LOG = Logger.getLogger(KafkaMetrics.class);
@Override
public void serverStarted(final String startupId) {
public void serverStart(final String startupId) {
LOG.trace(String.format("serverStarted(%s)", startupId));
}
@ -73,7 +73,7 @@ public class KafkaMetrics implements Metrics {
}
@Override
public void roundJudged(final String gameId, final String judgeSessionId,
public void roundComplete(final String gameId, final String judgeSessionId,
final String winnerSessionId,
final Map<User, List<WhiteCard>> cards) {
LOG.trace(String.format("roundJudged(%s, %s, %s, %s)", gameId, judgeSessionId, winnerSessionId,

4
src/main/java/net/socialgamer/cah/metrics/Metrics.java
View File

@ -42,7 +42,7 @@ import com.maxmind.geoip2.model.CityResponse;
* @author Andy Janata (ajanata@socialgamer.net)
*/
public interface Metrics {
void serverStarted(String startupId);
void serverStart(String startupId);
void newUser(String persistentId, String sessionId, @Nullable CityResponse geoIp,
String agentName, String agentType, String agentOs, String agentLanguage);
@ -51,7 +51,7 @@ public interface Metrics {
// The card data is way too complicated to dictate the format it should be in, so let
// implementations deal with the structured data.
void roundJudged(String gameId, String judgeSessionId, String winnerSessionId,
void roundComplete(String gameId, String judgeSessionId, String winnerSessionId,
Map<User, List<WhiteCard>> cards);
void gameStart(String gameId, Collection<CardSet> decks, int blanks, int maxPlayers,

4
src/main/java/net/socialgamer/cah/metrics/NoOpMetrics.java
View File

@ -48,7 +48,7 @@ public class NoOpMetrics implements Metrics {
private static final Logger LOG = Logger.getLogger(NoOpMetrics.class);
@Override
public void serverStarted(final String startupId) {
public void serverStart(final String startupId) {
LOG.trace(String.format("serverStarted(%s)", startupId));
}
@ -73,7 +73,7 @@ public class NoOpMetrics implements Metrics {
}
@Override
public void roundJudged(final String gameId, final String judgeSessionId,
public void roundComplete(final String gameId, final String judgeSessionId,
final String winnerSessionId,
final Map<User, List<WhiteCard>> cards) {
LOG.trace(String.format("roundJudged(%s, %s, %s, %s)", gameId, judgeSessionId, winnerSessionId,