Wrap TimerTask.run in a try-catch so an exception can't kill all processing.

src/net/socialgamer/cah/SafeTimerTask.java

@@ -0,0 +1,23 @@
+package net.socialgamer.cah;
+
+import java.util.TimerTask;
+
+import org.apache.log4j.Logger;
+
+
+public abstract class SafeTimerTask extends TimerTask {
+
+  private static final Logger logger = Logger.getLogger(SafeTimerTask.class);
+
+  @Override
+  public final void run() {
+    try {
+      process();
+    } catch (final Exception e) {
+      logger.error("Exception running SafeTimerTask", e);
+    }
+  }
+
+  public abstract void process();
+
+}

src/net/socialgamer/cah/UserPing.java

@@ -23,8 +23,6 @@
 
 package net.socialgamer.cah;
 
-import java.util.TimerTask;
-
 import net.socialgamer.cah.data.ConnectedUsers;
 
 import com.google.inject.Inject;
@@ -35,7 +33,7 @@ import com.google.inject.Inject;
  * 
  * @author Andy Janata (ajanata@gmail.com)
  */
-public class UserPing extends TimerTask {
+public class UserPing extends SafeTimerTask {
 
   private final ConnectedUsers users;
 
@@ -45,7 +43,7 @@ public class UserPing extends TimerTask {
   }
 
   @Override
-  public void run() {
+  public void process() {
     users.checkForPingAndIdleTimeouts();
   }
 }

src/net/socialgamer/cah/data/Game.java

@@ -34,7 +34,6 @@ import java.util.List;
 import java.util.Map;
 import java.util.Set;
 import java.util.Timer;
-import java.util.TimerTask;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
@@ -49,6 +48,7 @@ import net.socialgamer.cah.Constants.LongPollEvent;
 import net.socialgamer.cah.Constants.LongPollResponse;
 import net.socialgamer.cah.Constants.ReturnableData;
 import net.socialgamer.cah.Constants.WhiteCardData;
+import net.socialgamer.cah.SafeTimerTask;
 import net.socialgamer.cah.data.GameManager.GameId;
 import net.socialgamer.cah.data.QueuedMessage.MessageType;
 import net.socialgamer.cah.db.BlackCard;
@@ -147,7 +147,7 @@ public class Game {
    * Lock to prevent missing timer updates.
    */
   private final Object roundTimerLock = new Object();
-  private volatile TimerTask lastTimerTask;
+  private volatile SafeTimerTask lastTimerTask;
   private final Timer globalTimer;
 
   private int scoreGoal = 8;
@@ -308,9 +308,9 @@ public class Game {
         resetState(true);
       } else if (wasJudge) {
         synchronized (roundTimerLock) {
-          final TimerTask task = new TimerTask() {
+          final SafeTimerTask task = new SafeTimerTask() {
             @Override
-            public void run() {
+            public void process() {
               startNextRound();
             }
           };
@@ -744,9 +744,9 @@ public class Game {
     broadcastToPlayers(MessageType.GAME_EVENT, data);
 
     synchronized (roundTimerLock) {
-      final TimerTask task = new TimerTask() {
+      final SafeTimerTask task = new SafeTimerTask() {
         @Override
-        public void run() {
+        public void process() {
           warnPlayersToPlay();
         }
       };
@@ -778,9 +778,9 @@ public class Game {
         }
       }
 
-      final TimerTask task = new TimerTask() {
+      final SafeTimerTask task = new SafeTimerTask() {
         @Override
-        public void run() {
+        public void process() {
           skipIdlePlayers();
         }
       };
@@ -802,9 +802,9 @@ public class Game {
         getJudge().getUser().enqueueMessage(q);
       }
 
-      final TimerTask task = new TimerTask() {
+      final SafeTimerTask task = new SafeTimerTask() {
         @Override
-        public void run() {
+        public void process() {
           skipIdleJudge();
         }
       };
@@ -907,7 +907,7 @@ public class Game {
     }
   }
 
-  private void rescheduleTimer(final TimerTask task, final long timeout) {
+  private void rescheduleTimer(final SafeTimerTask task, final long timeout) {
     synchronized (roundTimerLock) {
       killRoundTimer();
       logger.trace(String.format("Scheduling timer task %s after %d ms", task, timeout));
@@ -937,9 +937,9 @@ public class Game {
     notifyPlayerInfoChange(getJudge());
 
     synchronized (roundTimerLock) {
-      final TimerTask task = new TimerTask() {
+      final SafeTimerTask task = new SafeTimerTask() {
         @Override
-        public void run() {
+        public void process() {
           warnJudgeToJudge();
         }
       };
@@ -1374,19 +1374,19 @@ public class Game {
     notifyPlayerInfoChange(cardPlayer);
 
     synchronized (roundTimerLock) {
-      final TimerTask task;
+      final SafeTimerTask task;
       // TODO win-by-x option
       if (cardPlayer.getScore() >= scoreGoal) {
-        task = new TimerTask() {
+        task = new SafeTimerTask() {
           @Override
-          public void run() {
+          public void process() {
             winState();
           }
         };
       } else {
-        task = new TimerTask() {
+        task = new SafeTimerTask() {
           @Override
-          public void run() {
+          public void process() {
             startNextRound();
           }
         };