mirrors
/
Tasmota
mirror of https://github.com/arendst/Tasmota.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix scripter buffer overflow (#20303)

This commit is contained in:
Theo Arends 2023-12-26 14:22:47 +01:00
parent b7b83eaaaa
commit c744612a29
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tasmota/tasmota_xdrv_driver/xdrv_10_scripter.ino
View File

@ -9349,8 +9349,10 @@ bool Script_SubCmd(void) {
cp += tlen;
if (XdrvMailbox.data_len > 0) {
*cp++ = '(';
strncpy(cp, XdrvMailbox.data,XdrvMailbox.data_len);
cp += XdrvMailbox.data_len;
uint32_t max_space = sizeof(cmdbuff) - tlen - 4; // 4 = #()0
uint32_t max_len = min(XdrvMailbox.data_len, max_space);
strncpy(cp, XdrvMailbox.data, max_len);
cp += max_len;
*cp++ = ')';
*cp = 0;
}