2018-09-18 15:45:58 +01:00
|
|
|
require 'rails_helper'
|
|
|
|
|
|
|
|
|
|
RSpec.describe VerifyLinkService, type: :service do
|
|
|
|
|
subject { described_class.new }
|
|
|
|
|
|
2018-10-04 14:47:03 +01:00
|
|
|
context 'given a local account' do
|
|
|
|
|
let(:account) { Fabricate(:account, username: 'alice') }
|
|
|
|
|
let(:field) { Account::Field.new(account, 'name' => 'Website', 'value' => 'http://example.com') }
|
2018-09-18 15:45:58 +01:00
|
|
|
|
2018-10-04 14:47:03 +01:00
|
|
|
before do
|
|
|
|
|
stub_request(:head, 'https://redirect.me/abc').to_return(status: 301, headers: { 'Location' => ActivityPub::TagManager.instance.url_for(account) })
|
|
|
|
|
stub_request(:get, 'http://example.com').to_return(status: 200, body: html)
|
|
|
|
|
subject.call(field)
|
2018-09-18 15:45:58 +01:00
|
|
|
end
|
|
|
|
|
|
2018-10-04 14:47:03 +01:00
|
|
|
context 'when a link contains an <a> back' do
|
|
|
|
|
let(:html) do
|
|
|
|
|
<<-HTML
|
|
|
|
|
<!doctype html>
|
|
|
|
|
<body>
|
|
|
|
|
<a href="#{ActivityPub::TagManager.instance.url_for(account)}" rel="me">Follow me on Mastodon</a>
|
|
|
|
|
</body>
|
|
|
|
|
HTML
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'marks the field as verified' do
|
|
|
|
|
expect(field.verified?).to be true
|
|
|
|
|
end
|
2018-09-18 15:45:58 +01:00
|
|
|
end
|
|
|
|
|
|
2019-10-24 21:44:42 +01:00
|
|
|
context 'when a link contains an <a rel="noopener noreferrer"> back' do
|
2018-10-04 14:47:03 +01:00
|
|
|
let(:html) do
|
|
|
|
|
<<-HTML
|
|
|
|
|
<!doctype html>
|
|
|
|
|
<body>
|
2019-10-24 21:44:42 +01:00
|
|
|
<a href="#{ActivityPub::TagManager.instance.url_for(account)}" rel="me noopener noreferrer" target="_blank">Follow me on Mastodon</a>
|
2018-10-04 14:47:03 +01:00
|
|
|
</body>
|
|
|
|
|
HTML
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'marks the field as verified' do
|
|
|
|
|
expect(field.verified?).to be true
|
|
|
|
|
end
|
2018-09-19 15:47:31 +01:00
|
|
|
end
|
|
|
|
|
|
2018-10-04 14:47:03 +01:00
|
|
|
context 'when a link contains a <link> back' do
|
|
|
|
|
let(:html) do
|
|
|
|
|
<<-HTML
|
|
|
|
|
<!doctype html>
|
|
|
|
|
<head>
|
|
|
|
|
<link type="text/html" href="#{ActivityPub::TagManager.instance.url_for(account)}" rel="me" />
|
|
|
|
|
</head>
|
|
|
|
|
HTML
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'marks the field as verified' do
|
|
|
|
|
expect(field.verified?).to be true
|
|
|
|
|
end
|
2018-09-19 15:47:31 +01:00
|
|
|
end
|
|
|
|
|
|
2018-10-04 14:47:03 +01:00
|
|
|
context 'when a link goes through a redirect back' do
|
|
|
|
|
let(:html) do
|
|
|
|
|
<<-HTML
|
|
|
|
|
<!doctype html>
|
|
|
|
|
<head>
|
|
|
|
|
<link type="text/html" href="https://redirect.me/abc" rel="me" />
|
|
|
|
|
</head>
|
|
|
|
|
HTML
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'marks the field as verified' do
|
|
|
|
|
expect(field.verified?).to be true
|
|
|
|
|
end
|
2018-09-18 15:45:58 +01:00
|
|
|
end
|
|
|
|
|
|
2023-01-11 20:59:13 +00:00
|
|
|
context 'when a document is truncated but the link back is valid' do
|
|
|
|
|
let(:html) do
|
|
|
|
|
"
|
|
|
|
|
<!doctype html>
|
|
|
|
|
<body>
|
|
|
|
|
<a rel=\"me\" href=\"#{ActivityPub::TagManager.instance.url_for(account)}\"
|
|
|
|
|
"
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'marks the field as not verified' do
|
|
|
|
|
expect(field.verified?).to be false
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'when a link back might be truncated' do
|
|
|
|
|
let(:html) do
|
|
|
|
|
"
|
|
|
|
|
<!doctype html>
|
|
|
|
|
<body>
|
|
|
|
|
<a rel=\"me\" href=\"#{ActivityPub::TagManager.instance.url_for(account)}"
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'does not mark the field as verified' do
|
|
|
|
|
expect(field.verified?).to be false
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2018-10-04 14:47:03 +01:00
|
|
|
context 'when a link does not contain a link back' do
|
|
|
|
|
let(:html) { '' }
|
|
|
|
|
|
2022-11-17 09:59:35 +00:00
|
|
|
it 'does not mark the field as verified' do
|
|
|
|
|
expect(field.verified?).to be false
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context 'when link has no `href` attribute' do
|
|
|
|
|
let(:html) do
|
|
|
|
|
<<-HTML
|
|
|
|
|
<!doctype html>
|
|
|
|
|
<head>
|
|
|
|
|
<link type="text/html" rel="me" />
|
|
|
|
|
</head>
|
|
|
|
|
<body>
|
|
|
|
|
<a rel="me" target="_blank">Follow me on Mastodon</a>
|
|
|
|
|
</body>
|
|
|
|
|
HTML
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'does not mark the field as verified' do
|
2018-10-04 14:47:03 +01:00
|
|
|
expect(field.verified?).to be false
|
|
|
|
|
end
|
2018-09-18 15:45:58 +01:00
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2018-10-04 14:47:03 +01:00
|
|
|
context 'given a remote account' do
|
|
|
|
|
let(:account) { Fabricate(:account, username: 'alice', domain: 'example.com', url: 'https://profile.example.com/alice') }
|
|
|
|
|
let(:field) { Account::Field.new(account, 'name' => 'Website', 'value' => '<a href="http://example.com" rel="me"><span class="invisible">http://</span><span class="">example.com</span><span class="invisible"></span></a>') }
|
2018-09-19 23:10:35 +01:00
|
|
|
|
2018-10-04 14:47:03 +01:00
|
|
|
before do
|
|
|
|
|
stub_request(:get, 'http://example.com').to_return(status: 200, body: html)
|
|
|
|
|
subject.call(field)
|
2018-09-19 23:10:35 +01:00
|
|
|
end
|
|
|
|
|
|
2018-10-04 14:47:03 +01:00
|
|
|
context 'when a link contains an <a> back' do
|
|
|
|
|
let(:html) do
|
|
|
|
|
<<-HTML
|
|
|
|
|
<!doctype html>
|
|
|
|
|
<body>
|
|
|
|
|
<a href="https://profile.example.com/alice" rel="me">Follow me on Mastodon</a>
|
|
|
|
|
</body>
|
|
|
|
|
HTML
|
|
|
|
|
end
|
2018-09-18 15:45:58 +01:00
|
|
|
|
2018-10-04 14:47:03 +01:00
|
|
|
it 'marks the field as verified' do
|
|
|
|
|
expect(field.verified?).to be true
|
|
|
|
|
end
|
2018-09-18 15:45:58 +01:00
|
|
|
end
|
2023-01-23 12:05:54 +00:00
|
|
|
|
|
|
|
|
context 'when the link contains a link with a missing protocol slash' do
|
|
|
|
|
# This was seen in the wild where a user had three pages:
|
|
|
|
|
# 1. their mastodon profile, which linked to github and the personal website
|
|
|
|
|
# 2. their personal website correctly linking back to mastodon
|
|
|
|
|
# 3. a github profile that was linking to the personal website, but with
|
|
|
|
|
# a malformed protocol of http:/
|
|
|
|
|
#
|
|
|
|
|
# This caused link verification between the mastodon profile and the
|
|
|
|
|
# website to fail.
|
|
|
|
|
#
|
|
|
|
|
# apparently github allows the user to enter website URLs with a single
|
|
|
|
|
# slash and makes no attempts to correct that.
|
|
|
|
|
let(:html) { '<a href="http:/unrelated.example">Hello</a>' }
|
|
|
|
|
|
|
|
|
|
it 'does not crash' do
|
|
|
|
|
# We could probably put more effort into perhaps auto-correcting the
|
|
|
|
|
# link and following it anyway, but at the very least we shouldn't let
|
|
|
|
|
# exceptions bubble up
|
|
|
|
|
expect(field.verified?).to be false
|
|
|
|
|
end
|
|
|
|
|
end
|
2018-09-18 15:45:58 +01:00
|
|
|
end
|
|
|
|
|
end
|
