2023-02-22 00:55:31 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-02-29 18:42:08 +00:00
|
|
|
require 'rails_helper'
|
|
|
|
|
2023-05-04 04:49:53 +01:00
|
|
|
RSpec.describe AccountsController do
|
2016-09-07 23:33:07 +01:00
|
|
|
render_views
|
|
|
|
|
2022-01-27 23:46:42 +00:00
|
|
|
let(:account) { Fabricate(:account) }
|
2016-02-29 18:42:08 +00:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
shared_examples 'unapproved account check' do
|
|
|
|
before { account.user.update(approved: false) }
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it 'returns http not found' do
|
|
|
|
get :show, params: { username: account.username, format: format }
|
2017-05-23 01:53:01 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
expect(response).to have_http_status(404)
|
2016-02-29 18:42:08 +00:00
|
|
|
end
|
2023-10-17 12:32:10 +01:00
|
|
|
end
|
2016-02-29 18:42:08 +00:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
shared_examples 'permanently suspended account check' do
|
|
|
|
before do
|
|
|
|
account.suspend!
|
|
|
|
account.deletion_request.destroy
|
2020-11-07 23:28:39 +00:00
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it 'returns http gone' do
|
|
|
|
get :show, params: { username: account.username, format: format }
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
expect(response).to have_http_status(410)
|
|
|
|
end
|
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
shared_examples 'temporarily suspended account check' do |code: 403|
|
|
|
|
before { account.suspend! }
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it 'returns appropriate http response code' do
|
|
|
|
get :show, params: { username: account.username, format: format }
|
2017-05-23 01:53:01 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
expect(response).to have_http_status(code)
|
|
|
|
end
|
|
|
|
end
|
2017-05-23 01:53:01 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
describe 'GET #show' do
|
|
|
|
context 'with basic account status checks' do
|
|
|
|
context 'with HTML' do
|
|
|
|
let(:format) { 'html' }
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it_behaves_like 'unapproved account check'
|
|
|
|
it_behaves_like 'permanently suspended account check'
|
|
|
|
it_behaves_like 'temporarily suspended account check'
|
2020-05-03 21:19:24 +01:00
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with JSON' do
|
|
|
|
let(:format) { 'json' }
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it_behaves_like 'unapproved account check'
|
|
|
|
it_behaves_like 'permanently suspended account check'
|
|
|
|
it_behaves_like 'temporarily suspended account check', code: 200
|
2020-05-03 21:19:24 +01:00
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with RSS' do
|
|
|
|
let(:format) { 'rss' }
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it_behaves_like 'unapproved account check'
|
|
|
|
it_behaves_like 'permanently suspended account check'
|
|
|
|
it_behaves_like 'temporarily suspended account check'
|
2016-09-07 23:33:07 +01:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with existing statuses' do
|
|
|
|
let!(:status) { Fabricate(:status, account: account) }
|
|
|
|
let!(:status_reply) { Fabricate(:status, account: account, thread: Fabricate(:status)) }
|
|
|
|
let!(:status_self_reply) { Fabricate(:status, account: account, thread: status) }
|
|
|
|
let!(:status_media) { Fabricate(:status, account: account) }
|
|
|
|
let!(:status_pinned) { Fabricate(:status, account: account) }
|
|
|
|
let!(:status_private) { Fabricate(:status, account: account, visibility: :private) }
|
|
|
|
let!(:status_direct) { Fabricate(:status, account: account, visibility: :direct) }
|
|
|
|
let!(:status_reblog) { Fabricate(:status, account: account, reblog: Fabricate(:status)) }
|
2017-11-09 13:36:17 +00:00
|
|
|
|
2020-05-03 21:19:24 +01:00
|
|
|
before do
|
2023-10-17 12:32:10 +01:00
|
|
|
status_media.media_attachments << Fabricate(:media_attachment, account: account, type: :image)
|
|
|
|
account.pinned_statuses << status_pinned
|
|
|
|
account.pinned_statuses << status_private
|
2020-05-03 21:19:24 +01:00
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with HTML' do
|
|
|
|
let(:format) { 'html' }
|
2020-11-07 23:28:39 +00:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
shared_examples 'common HTML response' do
|
|
|
|
it 'returns a standard HTML response', :aggregate_failures do
|
|
|
|
expect(response).to have_http_status(200)
|
2020-11-07 23:28:39 +00:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
expect(response.headers['Link'].to_s).to include ActivityPub::TagManager.instance.uri_for(account)
|
2020-11-07 23:28:39 +00:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
expect(response).to render_template(:show)
|
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with a normal account in an HTML request' do
|
|
|
|
before do
|
|
|
|
get :show, params: { username: account.username, format: format }
|
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it_behaves_like 'common HTML response'
|
2020-05-03 21:19:24 +01:00
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with replies' do
|
|
|
|
before do
|
|
|
|
allow(controller).to receive(:replies_requested?).and_return(true)
|
|
|
|
get :show, params: { username: account.username, format: format }
|
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it_behaves_like 'common HTML response'
|
2020-05-03 21:19:24 +01:00
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with media' do
|
|
|
|
before do
|
|
|
|
allow(controller).to receive(:media_requested?).and_return(true)
|
|
|
|
get :show, params: { username: account.username, format: format }
|
2017-11-09 13:36:17 +00:00
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it_behaves_like 'common HTML response'
|
2020-05-03 21:19:24 +01:00
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with tag' do
|
|
|
|
let(:tag) { Fabricate(:tag) }
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
let!(:status_tag) { Fabricate(:status, account: account) }
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
before do
|
|
|
|
allow(controller).to receive(:tag_requested?).and_return(true)
|
|
|
|
status_tag.tags << tag
|
|
|
|
get :show, params: { username: account.username, format: format, tag: tag.to_param }
|
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it_behaves_like 'common HTML response'
|
2020-05-03 21:19:24 +01:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with JSON' do
|
|
|
|
let(:authorized_fetch_mode) { false }
|
|
|
|
let(:format) { 'json' }
|
2020-05-03 21:19:24 +01:00
|
|
|
|
|
|
|
before do
|
2023-10-17 12:32:10 +01:00
|
|
|
allow(controller).to receive(:authorized_fetch_mode?).and_return(authorized_fetch_mode)
|
2020-05-03 21:19:24 +01:00
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with a normal account in a JSON request' do
|
|
|
|
before do
|
|
|
|
get :show, params: { username: account.username, format: format }
|
|
|
|
end
|
2017-05-23 01:53:01 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it 'returns a JSON version of the account', :aggregate_failures do
|
2020-05-03 21:19:24 +01:00
|
|
|
expect(response).to have_http_status(200)
|
|
|
|
|
2021-03-17 09:09:55 +00:00
|
|
|
expect(response.media_type).to eq 'application/activity+json'
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
expect(body_as_json).to include(:id, :type, :preferredUsername, :inbox, :publicKey, :name, :summary)
|
2017-11-09 13:36:17 +00:00
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it_behaves_like 'cacheable response', expects_vary: 'Accept, Accept-Language, Cookie'
|
2016-09-07 23:33:07 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with authorized fetch mode' do
|
|
|
|
let(:authorized_fetch_mode) { true }
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it 'returns http unauthorized' do
|
|
|
|
expect(response).to have_http_status(401)
|
|
|
|
end
|
|
|
|
end
|
2020-11-07 23:28:39 +00:00
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'when signed in' do
|
|
|
|
let(:user) { Fabricate(:user) }
|
2020-11-07 23:28:39 +00:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
get :show, params: { username: account.username, format: format }
|
|
|
|
end
|
2017-11-09 13:36:17 +00:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it 'returns a private JSON version of the account', :aggregate_failures do
|
|
|
|
expect(response).to have_http_status(200)
|
2017-11-09 13:36:17 +00:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
expect(response.media_type).to eq 'application/activity+json'
|
2017-11-09 13:36:17 +00:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
expect(response.headers['Cache-Control']).to include 'private'
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
expect(body_as_json).to include(:id, :type, :preferredUsername, :inbox, :publicKey, :name, :summary)
|
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
end
|
2017-11-09 13:36:17 +00:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with signature' do
|
|
|
|
let(:remote_account) { Fabricate(:account, domain: 'example.com') }
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
before do
|
|
|
|
allow(controller).to receive(:signed_request_actor).and_return(remote_account)
|
|
|
|
get :show, params: { username: account.username, format: format }
|
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it 'returns a JSON version of the account', :aggregate_failures do
|
|
|
|
expect(response).to have_http_status(200)
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
expect(response.media_type).to eq 'application/activity+json'
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
expect(body_as_json).to include(:id, :type, :preferredUsername, :inbox, :publicKey, :name, :summary)
|
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it_behaves_like 'cacheable response', expects_vary: 'Accept, Accept-Language, Cookie'
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with authorized fetch mode' do
|
|
|
|
let(:authorized_fetch_mode) { true }
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it 'returns a private signature JSON version of the account', :aggregate_failures do
|
|
|
|
expect(response).to have_http_status(200)
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
expect(response.media_type).to eq 'application/activity+json'
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
expect(response.headers['Cache-Control']).to include 'private'
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
expect(response.headers['Vary']).to include 'Signature'
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
expect(body_as_json).to include(:id, :type, :preferredUsername, :inbox, :publicKey, :name, :summary)
|
|
|
|
end
|
|
|
|
end
|
2017-11-09 13:36:17 +00:00
|
|
|
end
|
2017-08-25 17:50:52 +01:00
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with RSS' do
|
|
|
|
let(:format) { 'rss' }
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
shared_examples 'common RSS response' do
|
|
|
|
it 'returns http success' do
|
|
|
|
expect(response).to have_http_status(200)
|
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it_behaves_like 'cacheable response', expects_vary: 'Accept, Accept-Language, Cookie'
|
2020-05-03 21:19:24 +01:00
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with a normal account in an RSS request' do
|
|
|
|
before do
|
|
|
|
get :show, params: { username: account.username, format: format }
|
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it_behaves_like 'common RSS response'
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it 'responds with correct statuses', :aggregate_failures do
|
|
|
|
expect(response.body).to include_status_tag(status_media)
|
|
|
|
expect(response.body).to include_status_tag(status_self_reply)
|
|
|
|
expect(response.body).to include_status_tag(status)
|
|
|
|
expect(response.body).to_not include_status_tag(status_direct)
|
|
|
|
expect(response.body).to_not include_status_tag(status_private)
|
|
|
|
expect(response.body).to_not include_status_tag(status_reblog.reblog)
|
|
|
|
expect(response.body).to_not include_status_tag(status_reply)
|
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with replies' do
|
|
|
|
before do
|
|
|
|
allow(controller).to receive(:replies_requested?).and_return(true)
|
|
|
|
get :show, params: { username: account.username, format: format }
|
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it_behaves_like 'common RSS response'
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it 'responds with correct statuses with replies', :aggregate_failures do
|
|
|
|
expect(response.body).to include_status_tag(status_media)
|
|
|
|
expect(response.body).to include_status_tag(status_reply)
|
|
|
|
expect(response.body).to include_status_tag(status_self_reply)
|
|
|
|
expect(response.body).to include_status_tag(status)
|
|
|
|
expect(response.body).to_not include_status_tag(status_direct)
|
|
|
|
expect(response.body).to_not include_status_tag(status_private)
|
|
|
|
expect(response.body).to_not include_status_tag(status_reblog.reblog)
|
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with media' do
|
|
|
|
before do
|
|
|
|
allow(controller).to receive(:media_requested?).and_return(true)
|
|
|
|
get :show, params: { username: account.username, format: format }
|
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it_behaves_like 'common RSS response'
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it 'responds with correct statuses with media', :aggregate_failures do
|
|
|
|
expect(response.body).to include_status_tag(status_media)
|
|
|
|
expect(response.body).to_not include_status_tag(status_direct)
|
|
|
|
expect(response.body).to_not include_status_tag(status_private)
|
|
|
|
expect(response.body).to_not include_status_tag(status_reblog.reblog)
|
|
|
|
expect(response.body).to_not include_status_tag(status_reply)
|
|
|
|
expect(response.body).to_not include_status_tag(status_self_reply)
|
|
|
|
expect(response.body).to_not include_status_tag(status)
|
|
|
|
end
|
2020-05-03 21:19:24 +01:00
|
|
|
end
|
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
context 'with tag' do
|
|
|
|
let(:tag) { Fabricate(:tag) }
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
let!(:status_tag) { Fabricate(:status, account: account) }
|
2020-05-03 21:19:24 +01:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
before do
|
|
|
|
allow(controller).to receive(:tag_requested?).and_return(true)
|
|
|
|
status_tag.tags << tag
|
|
|
|
get :show, params: { username: account.username, format: format, tag: tag.to_param }
|
|
|
|
end
|
2017-11-09 13:36:17 +00:00
|
|
|
|
2023-10-17 12:32:10 +01:00
|
|
|
it_behaves_like 'common RSS response'
|
|
|
|
|
|
|
|
it 'responds with correct statuses with a tag', :aggregate_failures do
|
|
|
|
expect(response.body).to include_status_tag(status_tag)
|
|
|
|
expect(response.body).to_not include_status_tag(status_direct)
|
|
|
|
expect(response.body).to_not include_status_tag(status_media)
|
|
|
|
expect(response.body).to_not include_status_tag(status_private)
|
|
|
|
expect(response.body).to_not include_status_tag(status_reblog.reblog)
|
|
|
|
expect(response.body).to_not include_status_tag(status_reply)
|
|
|
|
expect(response.body).to_not include_status_tag(status_self_reply)
|
|
|
|
expect(response.body).to_not include_status_tag(status)
|
|
|
|
end
|
2017-11-09 13:36:17 +00:00
|
|
|
end
|
2016-09-07 23:33:07 +01:00
|
|
|
end
|
2016-02-29 18:42:08 +00:00
|
|
|
end
|
|
|
|
end
|
2023-10-17 12:32:10 +01:00
|
|
|
|
|
|
|
def include_status_tag(status)
|
|
|
|
include ActivityPub::TagManager.instance.url_for(status)
|
|
|
|
end
|
2016-02-29 18:42:08 +00:00
|
|
|
end
|