Fix several smaller JS lint errors

app/javascript/mastodon/components/status_content.jsx

@@ -2,6 +2,7 @@ import PropTypes from 'prop-types';
 import { PureComponent } from 'react';
 
 import { FormattedMessage, injectIntl } from 'react-intl';
+
 import classnames from 'classnames';
 import { Link } from 'react-router-dom';
 
@@ -10,7 +11,7 @@ import { connect } from 'react-redux';
 
 import { Icon }  from 'mastodon/components/icon';
 import PollContainer from 'mastodon/containers/poll_container';
-import { autoPlayGif, languages as preloadedLanguages } from 'mastodon/initial_state';
+import { autoPlayGif, languages as preloadedLanguages, expandUsernames } from 'mastodon/initial_state';
 
 const MAX_HEIGHT = 706; // 22px * 32 (+ 2px padding at the top)
 
@@ -283,11 +284,9 @@ class StatusContent extends PureComponent {
       let mentionsPlaceholder = '';
 
       const mentionLinks = status.get('mentions').map(item => (
-        <Permalink to={`/@${item.get('acct')}`} href={item.get('url')} key={item.get('id')} className='status-link mention'>
+        <Link to={`/@${item.get('acct')}`} href={item.get('url')} key={item.get('id')} className='status-link mention'>
-          @<span className={item.get('acct') === item.get('username') ? 'fc_mention_local' : 'fc_mention_remote'}>
+          @<span>{expandUsernames ? item.get('acct') : item.get('username')}</span>
-            {expandUsernames ? item.get('acct') : item.get('username')}
+        </Link>
-          </span>
-        </Permalink>
       )).reduce((aggregate, item) => [...aggregate, item, ' '], []);
 
       const toggleText = hidden ? <FormattedMessage id='status.show_more' defaultMessage='Show more' /> : <FormattedMessage id='status.show_less' defaultMessage='Show less' />;
@@ -297,7 +296,7 @@ class StatusContent extends PureComponent {
       }
 
       const output = [
-        <div className={classNames} ref={this.setRef} tabIndex={0} onMouseDown={this.handleMouseDown} onMouseUp={this.handleMouseUp} onMouseEnter={this.handleMouseEnter} onMouseLeave={this.handleMouseLeave}>
+        <div key={"__yells_at_linter__"} className={classNames} ref={this.setRef} tabIndex={0} onMouseDown={this.handleMouseDown} onMouseUp={this.handleMouseUp} onMouseEnter={this.handleMouseEnter} onMouseLeave={this.handleMouseLeave}>
           <p style={{ marginBottom: hidden && status.get('mentions').isEmpty() ? '0px' : null }}>
             <span dangerouslySetInnerHTML={spoilerContent} className='translate' lang={language} />
             {' '}
@@ -306,7 +305,8 @@ class StatusContent extends PureComponent {
 
           {mentionsPlaceholder}
 
-          <div tabIndex={!hidden ? 0 : null} className={`status__content__text ${!hidden ? 'status__content__text--visible' : ''} ${status.get('activity_pub_type') === 'Article' ? 'article-type' : ''} translate`} lang={lang} dangerouslySetInnerHTML={content} />
+          <div tabIndex={!hidden ? 0 : null} className={`status__content__text ${!hidden ? 'status__content__text--visible' : ''} ${status.get('activity_pub_type') === 'Article' ? 'article-type' : ''} translate`} lang={language} dangerouslySetInnerHTML={content} />
+
           {!hidden && poll}
           {translateButton}
         </div>,

app/javascript/mastodon/features/account_timeline/components/moved_note.jsx

@@ -1,4 +1,5 @@
 import { FormattedMessage } from 'react-intl';
+
 import { Link } from 'react-router-dom';
 
 import ImmutablePropTypes from 'react-immutable-proptypes';

app/javascript/mastodon/features/compose/components/compose_form.jsx

@@ -14,6 +14,7 @@ import { Icon }  from 'mastodon/components/icon';
 import AutosuggestInput from '../../../components/autosuggest_input';
 import AutosuggestTextarea from '../../../components/autosuggest_textarea';
 import Button from '../../../components/button';
+import { maxChars } from '../../../initial_state';
 import EmojiPickerDropdown from '../containers/emoji_picker_dropdown_container';
 import FederationDropdownContainer from '../containers/federation_dropdown_container';
 import LanguageDropdown from '../containers/language_dropdown_container';
@@ -26,7 +27,7 @@ import UploadButtonContainer from '../containers/upload_button_container';
 import UploadFormContainer from '../containers/upload_form_container';
 import WarningContainer from '../containers/warning_container';
 import { countableText } from '../util/counter';
-import { maxChars } from '../../../initial_state';
+
 import CharacterCounter from './character_counter';
 
 const allowedAroundShortCode = '><\u0085\u0020\u00a0\u1680\u2000\u2001\u2002\u2003\u2004\u2005\u2006\u2007\u2008\u2009\u200a\u202f\u205f\u3000\u2028\u2029\u0009\u000a\u000b\u000c\u000d';

app/javascript/mastodon/features/compose/components/emoji_picker_dropdown.jsx

@@ -386,11 +386,11 @@ class EmojiPickerDropdown extends PureComponent {
     return (
       <div className='emoji-picker-dropdown' onKeyDown={this.handleKeyDown}>
         <div ref={this.setTargetRef} className='emoji-button' title={title} aria-label={title} aria-expanded={active} role='button' onClick={this.onToggle} onKeyDown={this.onToggle} tabIndex={0}>
-          <img
+          {button || <img
             className={classNames('emojione', { 'pulse-loading': active && loading })}
             alt='🙂'
             src={`${assetHost}/emoji/1f642.svg`}
-          />
+          />}
         </div>
 
         <Overlay show={active} placement={'bottom'} target={this.findTarget} popperConfig={{ strategy: 'fixed' }}>

app/javascript/mastodon/features/compose/components/navigation_bar.jsx

@@ -1,5 +1,7 @@
 import PropTypes from 'prop-types';
+
 import { FormattedMessage } from 'react-intl';
+
 import { Link } from 'react-router-dom';
 
 import ImmutablePropTypes from 'react-immutable-proptypes';

app/javascript/mastodon/features/compose/components/poll_form.jsx

@@ -7,7 +7,9 @@ import classNames from 'classnames';
 
 import ImmutablePropTypes from 'react-immutable-proptypes';
 import ImmutablePureComponent from 'react-immutable-pure-component';
+
 import Toggle from 'react-toggle';
+
 import AutosuggestInput from 'mastodon/components/autosuggest_input';
 import { Icon }  from 'mastodon/components/icon';
 import { IconButton } from 'mastodon/components/icon_button';
@@ -163,7 +165,7 @@ class PollForm extends ImmutablePureComponent {
           {options.map((title, i) => <Option title={title} lang={lang} key={i} index={i} onChange={onChangeOption} onRemove={onRemoveOption} isPollMultiple={isMultiple} onToggleMultiple={this.handleToggleMultiple} autoFocus={i === autoFocusIndex} {...other} />)}
         </ul>
         <div className='is-multiple-toggle'>
-          <Toggle className='is-multiple-checkbox' checked={isMultiple} onChange={this.handleToggleMultiple}/>
+          <Toggle className='is-multiple-checkbox' checked={isMultiple} onChange={this.handleToggleMultiple} />
           <span className='is-multiple-toggle__label'>
             <FormattedMessage id='poll.is_multiple' defaultMessage='Multiple choice' />
           </span>

app/javascript/mastodon/features/compose/containers/federation_dropdown_container.js

@@ -1,8 +1,9 @@
 import { connect } from 'react-redux';
-import FederationDropdown from '../components/federation_dropdown';
+
 import { changeComposeFederation } from '../../../actions/compose';
 import { openModal, closeModal } from '../../../actions/modal';
 import { isUserTouching } from '../../../is_mobile';
+import FederationDropdown from '../components/federation_dropdown';
 
 const mapStateToProps = state => ({
   isModalOpen: state.get('modal').modalType === 'ACTIONS',

app/javascript/mastodon/features/compose/index.jsx

@@ -1,4 +1,3 @@
-import ColumnHeader from 'mastodon/components/column_header';
 import PropTypes from 'prop-types';
 import { PureComponent } from 'react';
 
@@ -14,6 +13,7 @@ import spring from 'react-motion/lib/spring';
 
 import { openModal } from 'mastodon/actions/modal';
 import Column from 'mastodon/components/column';
+import ColumnHeader from 'mastodon/components/column_header';
 import { Icon }  from 'mastodon/components/icon';
 import { logOut } from 'mastodon/utils/log_out';
 

app/javascript/mastodon/features/direct_timeline/components/conversation.jsx

@@ -7,6 +7,7 @@ import { Link } from 'react-router-dom';
 
 import ImmutablePropTypes from 'react-immutable-proptypes';
 import ImmutablePureComponent from 'react-immutable-pure-component';
+
 import { HotKeys } from 'react-hotkeys';
 
 import AttachmentList from 'mastodon/components/attachment_list';

app/javascript/mastodon/features/directory/components/account_card.jsx

@@ -1,4 +1,5 @@
 import PropTypes from 'prop-types';
+
 import { FormattedMessage, injectIntl, defineMessages } from 'react-intl';
 
 import classNames from 'classnames';

app/javascript/mastodon/features/follow_requests/components/account_authorize.jsx

@@ -1,4 +1,5 @@
 import PropTypes from 'prop-types';
+
 import { defineMessages, injectIntl } from 'react-intl';
 
 import { Link } from 'react-router-dom';

app/javascript/mastodon/features/notifications/components/follow_request.jsx

@@ -1,4 +1,5 @@
 import PropTypes from 'prop-types';
+
 import { defineMessages, injectIntl } from 'react-intl';
 
 import { Link } from 'react-router-dom';

app/javascript/mastodon/features/notifications/components/notification.jsx

@@ -1,5 +1,7 @@
 import PropTypes from 'prop-types';
+
 import { injectIntl, FormattedMessage, defineMessages } from 'react-intl';
+
 import classNames from 'classnames';
 import { Link } from 'react-router-dom';
 

app/javascript/mastodon/features/ui/index.jsx

@@ -192,6 +192,7 @@ class SwitchingColumnsArea extends PureComponent {
 
           <WrappedRoute path='/getting-started' component={GettingStarted} content={children} />
           <WrappedRoute path='/keyboard-shortcuts' component={KeyboardShortcuts} content={children} />
+          <WrappedRoute path='/about' component={About} content={children} />
           <WrappedRoute path='/privacy-policy' component={PrivacyPolicy} content={children} />
 
           <WrappedRoute path={['/home', '/timelines/home']} component={HomeTimeline} content={children} />