Fix MicroPython alloc'd bytearray support in APA102 driver
A bytearray allocated in Python would point to uninitialised bytes, missing the SOF byte and brightness for APA102 pixels. Add a blunt loop over the MicroPython buffer, calling "brightness" for each RGB element to ensure the SOF byte and brightness are initialized.
This commit is contained in:
parent
bb23ba22db
commit
5abdad05a8
|
@ -268,22 +268,29 @@ mp_obj_t PlasmaAPA102_make_new(const mp_obj_type_t *type, size_t n_args, size_t
|
|||
int clk = args[ARG_clk].u_int;
|
||||
int freq = args[ARG_freq].u_int;
|
||||
|
||||
void *buffer = nullptr;
|
||||
APA102::RGB *buffer = nullptr;
|
||||
|
||||
if (args[ARG_buffer].u_obj) {
|
||||
mp_buffer_info_t bufinfo;
|
||||
mp_get_buffer_raise(args[ARG_buffer].u_obj, &bufinfo, MP_BUFFER_RW);
|
||||
buffer = bufinfo.buf;
|
||||
buffer = (APA102::RGB *)bufinfo.buf;
|
||||
if(bufinfo.len < (size_t)(num_leds * 4)) {
|
||||
mp_raise_ValueError("Supplied buffer is too small for LED count!");
|
||||
}
|
||||
// If a bytearray is supplied it'll be raw, uninitialized bytes
|
||||
// iterate through the RGB elements and call "brightness"
|
||||
// to set up the SOF bytes, otherwise a flickery mess will happen!
|
||||
// Oh for such niceties as "placement new"...
|
||||
for(auto i = 0; i < num_leds; i++) {
|
||||
buffer[i].brightness(15);
|
||||
}
|
||||
}
|
||||
|
||||
self = m_new_obj_with_finaliser(_PlasmaAPA102_obj_t);
|
||||
self->base.type = &PlasmaAPA102_type;
|
||||
self->buf = buffer;
|
||||
|
||||
self->apa102 = new APA102(num_leds, pio, sm, dat, clk, freq, (APA102::RGB *)buffer);
|
||||
self->apa102 = new APA102(num_leds, pio, sm, dat, clk, freq, buffer);
|
||||
|
||||
return MP_OBJ_FROM_PTR(self);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue