mirrors
/
tailscale
mirror of https://github.com/tailscale/tailscale.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

util/linuxfw: fix crash in DelSNATRule when no rules are found 

Appears to be a missing nil handling case. I looked back over other
usage of findRule and the others all have nil guards. findRule returns
nil when no rules are found matching the arguments.

Fixes #9553
Signed-off-by: James Tucker <james@tailscale.com>
This commit is contained in:
James Tucker 2023-09-27 10:56:11 -07:00 committed by James Tucker
parent 697f92f4a7
commit 2066f9fbb2
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/linuxfw/nftables_runner.go
View File

@ -1109,7 +1109,9 @@ func (n *nftablesRunner) DelSNATRule() error {
return fmt.Errorf("find SNAT rule v4: %w", err) return fmt.Errorf("find SNAT rule v4: %w", err)
} }
_ = conn.DelRule(SNATRule) if SNATRule != nil {
_ = conn.DelRule(SNATRule)
}
} }
if err := conn.Flush(); err != nil { if err := conn.Flush(); err != nil {