net/dns: teach the openresolv manager to read DNS config.

Signed-off-by: David Anderson <danderson@tailscale.com>
This commit is contained in:
David Anderson 2021-04-10 19:37:11 -07:00
parent 19eca34f47
commit 61b361bac0
2 changed files with 36 additions and 11 deletions

View File

@ -44,15 +44,8 @@ func writeResolvConf(w io.Writer, servers []netaddr.IP, domains []dnsname.FQDN)
} }
} }
func readResolvFile(path string) (OSConfig, error) { func readResolv(r io.Reader) (config OSConfig, err error) {
var config OSConfig scanner := bufio.NewScanner(r)
f, err := os.Open(path)
if err != nil {
return config, err
}
scanner := bufio.NewScanner(f)
for scanner.Scan() { for scanner.Scan() {
line := strings.TrimSpace(scanner.Text()) line := strings.TrimSpace(scanner.Text())
@ -61,7 +54,7 @@ func readResolvFile(path string) (OSConfig, error) {
nameserver = strings.TrimSpace(nameserver) nameserver = strings.TrimSpace(nameserver)
ip, err := netaddr.ParseIP(nameserver) ip, err := netaddr.ParseIP(nameserver)
if err != nil { if err != nil {
return config, err return OSConfig{}, err
} }
config.Nameservers = append(config.Nameservers, ip) config.Nameservers = append(config.Nameservers, ip)
continue continue
@ -82,6 +75,18 @@ func readResolvFile(path string) (OSConfig, error) {
return config, nil return config, nil
} }
func readResolvFile(path string) (OSConfig, error) {
var config OSConfig
f, err := os.Open(path)
if err != nil {
return config, err
}
defer f.Close()
return readResolv(f)
}
// readResolvConf reads DNS configuration from /etc/resolv.conf. // readResolvConf reads DNS configuration from /etc/resolv.conf.
func readResolvConf() (OSConfig, error) { func readResolvConf() (OSConfig, error) {
return readResolvFile(resolvConf) return readResolvFile(resolvConf)

View File

@ -8,6 +8,7 @@ import (
"bytes" "bytes"
"fmt" "fmt"
"os/exec" "os/exec"
"strings"
) )
// resolvconfIsOpenresolv reports whether the `resolvconf` binary on // resolvconfIsOpenresolv reports whether the `resolvconf` binary on
@ -48,7 +49,26 @@ func (m openresolvManager) SupportsSplitDNS() bool {
} }
func (m openresolvManager) GetBaseConfig() (OSConfig, error) { func (m openresolvManager) GetBaseConfig() (OSConfig, error) {
return OSConfig{}, ErrGetBaseConfigNotSupported bs, err := exec.Command("resolvconf", "-i").CombinedOutput()
if err != nil {
return OSConfig{}, err
}
args := []string{"-l"}
for _, f := range strings.Split(strings.TrimSpace(string(bs)), " ") {
if f == "tailscale" {
continue
}
args = append(args, f)
}
var buf bytes.Buffer
cmd := exec.Command("resolvconf", args...)
cmd.Stdout = &buf
if err := cmd.Run(); err != nil {
return OSConfig{}, err
}
return readResolv(&buf)
} }
func (m openresolvManager) Close() error { func (m openresolvManager) Close() error {