mirrors
/
tailscale
mirror of https://github.com/tailscale/tailscale.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ssh/tailssh: remove deprecated local recording envknob 

It is now exposed as a bool that must be toggled at compile time.

Updates tailscale/corp#9967

Signed-off-by: Maisem Ali <maisem@tailscale.com>
This commit is contained in:
Maisem Ali 2023-09-02 17:10:38 -07:00
parent 1262df0578
commit a0dadf584d
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
ssh/tailssh/tailssh.go
View File

@ -45,6 +45,7 @@ import (
"tailscale.com/util/clientmetric"
"tailscale.com/util/mak"
"tailscale.com/util/multierr"
"tailscale.com/version"
)
var (
@ -1188,10 +1189,18 @@ func (ss *sshSession) run() {
return
}
// recordSSHToLocalDisk is a deprecated dev knob to allow recording SSH sessions
// to local storage. It is only used if there is no recording configured by the
// coordination server. This will be removed in the future.
var recordSSHToLocalDisk = envknob.RegisterBool("TS_DEBUG_LOG_SSH")
var debugLogSSH = envknob.RegisterBool("TS_DEBUG_LOG_SSH")
// recordSSHToLocalDisk is a dev knob to allow recording SSH sessions to local
// storage. It is only used if there is no recording configured by the
// coordination server. It is only enabled in dev builds for testing, for
// production use recorders should be configured by the coordination server.
func recordSSHToLocalDisk() bool {
if !version.GetMeta().IsDev {
return false
}
return debugLogSSH()
}
// recorders returns the list of recorders to use for this session.
// If the final action has a non-empty list of recorders, that list is