mirrors
/
tailscale
mirror of https://github.com/tailscale/tailscale.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,580 Commits 690 Branches 155 Tags 223 MiB
Commit Graph

299 Commits

Author SHA1 Message Date
Josh Bleecher Snyder 25eab78573 control/noise: clean up resources in TestNoReuse 
Close the server and client.
Without this, we leak system threads.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
 2021-12-01 12:50:21 -08:00
Josh Bleecher Snyder d9c21936c3 control/controlclient: stop logging about goal.url invariant 
This isn't the ideal solution, but it's good enough for now.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
 2021-11-29 14:00:53 -08:00
Josh Bleecher Snyder 758c37b83d net/netns: thread logf into control functions 
So that darwin can log there without panicking during tests.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
 2021-11-18 15:09:51 -08:00
Brad Fitzpatrick 24ea365d48 netcheck, controlclient, magicsock: add more metrics 
Updates #3307

Change-Id: Ibb33425764a75bde49230632f1b472f923551126
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-11-16 10:48:19 -08:00
David Anderson 5b94f67956 control/noise: make Conn.readNLocked less surprising. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-10 12:13:54 -08:00
David Anderson a34350ffda control/noise: factor out nonce checking and incrementing into a type. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-10 12:13:54 -08:00
David Anderson d3acd35a90 control/noise: make message headers match the specification. 
Only the initiation message should carry a protocol version, all
others are just type+len.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-10 12:13:54 -08:00
David Anderson a63c4ab378 control/noise: don't panic when handling ciphertext. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-10 12:13:54 -08:00
David Anderson 4004b22fe5 control/noise: stop using poly1305 package constants. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-10 12:13:54 -08:00
David Anderson 293431aaea control/noise: use key.Machine{Public,Private} as appropriate. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-10 12:13:54 -08:00
David Anderson edb33d65c3 control/noise: don't cache mixer, just rebuild a BLAKE2s each time. 
This should optimize out fine, and readability is preferable to performance
here.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-10 12:13:54 -08:00
David Anderson 7e9e72887c control/noise: add singleUseCHP, use it to simplify nonce/key tracking in handshake. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-10 12:13:54 -08:00
David Anderson cf90392174 control/noise: review fixups 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-10 12:13:54 -08:00
David Anderson 0b392dbaf7 control/noise: adjust implementation to match revised spec. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-10 12:13:54 -08:00
David Anderson 89a68a4c22 control/noise: include the protocol version in the Noise prologue. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-10 12:13:54 -08:00
David Anderson 5e005a658f control/noise: fix typo in docstring. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-10 12:13:54 -08:00
David Anderson eabca699ec control/noise: remove allocations in the encrypt and decrypt paths. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-10 12:13:54 -08:00
David Anderson da7544bcc5 control/noise: implement the base transport for the 2021 control protocol. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-10 12:13:54 -08:00
Brad Fitzpatrick 3e1daab704 hostinfo, control/controlclient: tell control when Ubuntu has disabled Tailscale's sources 
Fixes #3177
Updates #2500

Change-Id: Iff2a8e27ec7d36a1c210263d6218f20ebed37924
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-11-10 09:56:58 -08:00
Brad Fitzpatrick d2ef73ed82 control/controlclient: rename a variable to not shadow a package name 
Change-Id: I1bcb577cb2c47e936d545ad57f308e57399de323
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-11-10 08:11:29 -08:00
Brad Fitzpatrick ad63fc0510 control/controlclient: make js/wasm work with Go 1.18+ 
Updates #3157

Change-Id: I2d67e582842ab3638d720bb5db4701b878ad4473
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-11-07 13:49:55 -08:00
Brad Fitzpatrick 337757a819 ipn/ipnlocal, control/controlclient: don't propagate all map errors to UI 
Fixes regression from 81cabf48ec which made
all map errors be sent to the frontend UI.

Fixes #3230

Change-Id: I7f142c801c7d15e268a24ddf901c3e6348b6729c
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-11-03 17:56:54 -07:00
David Anderson 0532eb30db all: replace tailcfg.DiscoKey with key.DiscoPublic. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-03 14:00:16 -07:00
David Anderson 7e6a1ef4f1 tailcfg: use key.NodePublic in wire protocol types. 
Updates #3206.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-02 09:11:43 -07:00
David Anderson d6e7cec6a7 types/netmap: use key.NodePublic instead of tailcfg.NodeKey. 
Update #3206

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-11-01 17:07:40 -07:00
Brad Fitzpatrick ff597e773e tailcfg, control/controlclient: add method to exit client from control plane 
Change-Id: Ic28ef283ba63396b68fab86bfb0a8ee8f432474c
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-11-01 11:59:04 -07:00
David Anderson 418adae379 various: use NodePublic.AsNodeKey() instead of tailcfg.NodeKeyFromNodePublic() 
Updates #3206

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-10-29 16:19:27 -07:00
David Anderson 4d38194c21 control/controlclient: stop using wgkey. 
Updates #3206

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-10-28 14:22:51 -07:00
Brad Fitzpatrick ada8cd99af control/controlclient: add a LoginEphemeral LoginFlags bit 
Change-Id: Ib9029ea0c49aa2ee1b6aac6e464ab1f16aef92e8
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-10-28 13:21:35 -07:00
David Anderson 6e5175373e types/netmap: use new node key type. 
Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-10-28 10:44:34 -07:00
David Anderson 0c546a28ba types/persist: use new node key type. 
Updates #3206

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-10-28 10:29:43 -07:00
Maisem Ali 81cabf48ec control/controlclient,tailcfg: propagate registration errors to the frontend 
Signed-off-by: Maisem Ali <maisem@tailscale.com>
 2021-10-27 06:57:26 -07:00
nicksherron f01ff18b6f all: fix spelling mistakes 
Signed-off-by: nicksherron <nsherron90@gmail.com>
 2021-10-12 21:23:14 -07:00
Brad Fitzpatrick aae622314e tailcfg, health: add way for control plane to add problems to health check 
So if the control plane knows that something's broken about the node, it can
include problem(s) in MapResponse and "tailscale status" will show it.
(and GUIs in the future, as it's in ipnstate.Status/JSON)

This also bumps the MapRequest.Version, though it's not strictly
required. Doesn't hurt.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-09-19 17:55:49 -07:00
Adrian Dewhurst 4da559d7cc control/controlclient: update machine certificate signature version 
This iterates on the original signature format.

Signed-off-by: Adrian Dewhurst <adrian@tailscale.com>
 2021-09-17 17:43:06 -04:00
Josh Bleecher Snyder 5b02ad16b9 control/controlclient: replace TODO with explanation 
Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
 2021-09-15 15:31:51 -07:00
Dave Anderson 980acc38ba
types/key: add a special key with custom serialization for control private keys (#2792) 
* Revert "Revert "types/key: add MachinePrivate and MachinePublic.""

This reverts commit 61c3b98a24.

Signed-off-by: David Anderson <danderson@tailscale.com>

* types/key: add ControlPrivate, with custom serialization.

ControlPrivate is just a MachinePrivate that serializes differently
in JSON, to be compatible with how the Tailscale control plane
historically serialized its private key.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-09-03 13:17:46 -07:00
David Anderson 61c3b98a24 Revert "types/key: add MachinePrivate and MachinePublic." 
Broke the tailscale control plane due to surprise different serialization.

This reverts commit 4fdb88efe1.
 2021-09-03 11:34:34 -07:00
David Anderson 4fdb88efe1 types/key: add MachinePrivate and MachinePublic. 
Plumb throughout the codebase as a replacement for the mixed use of
tailcfg.MachineKey and wgkey.Private/Public.

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-09-03 10:07:15 -07:00
David Anderson daf54d1253 control/controlclient: remove TS_DEBUG_USE_DISCO=only. 
It was useful early in development when disco clients were the
exception and tailscale logs were noisier than today, but now
non-disco is the exception.

Updates #2752

Signed-off-by: David Anderson <danderson@tailscale.com>
 2021-09-01 18:11:32 -07:00
slowy07 ac0353e982 fix: typo spelling grammar 
Signed-off-by: slowy07 <slowy.arfy@gmail.com>
 2021-08-24 07:55:04 -07:00
Brad Fitzpatrick 47045265b9 hostinfo: add SetDeviceModel setter, move remaining code from controlclient 
Updates tailscale/corp#1959

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-08-20 10:45:22 -07:00
Brad Fitzpatrick 6f8c8c771b control/controlclient: tweak a couple error messages 
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-08-18 10:11:38 -07:00
Simeng He e199e407d2 tailcfg: add IP and Types field to PingRequest 
Signed-off-by: Simeng He <simeng@tailscale.com>
 2021-08-18 12:23:24 -04:00
Josh Bleecher Snyder 4c8b5fdec4 control/controlclient: do not periodically print full netmap 
The netmaps can get really large.
Printing, processing, and uploading them is expensive.
Only print the header on an ongoing basis.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
 2021-08-17 12:57:49 -07:00
Josh Bleecher Snyder a5da4ed981 all: gofmt with Go 1.17 
This adds "//go:build" lines and tidies up existing "// +build" lines.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
 2021-08-05 15:54:00 -07:00
Brad Fitzpatrick dfa5e38fad control/controlclient: report whether we're in a snap package 
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-07-26 15:16:40 -07:00
Brad Fitzpatrick 4a2c3e2a0a control/controlclient: grow goroutine debug buffer as needed 
To not allocate 1MB up front on iOS.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-07-22 13:18:05 -07:00
Brad Fitzpatrick 1986d071c3 control/controlclient: don't use regexp in goroutine stack scrubbing 
To reduce binary size on iOS.

Updates tailscale/corp#2238

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-07-22 13:18:05 -07:00
Brad Fitzpatrick 171ec9f8f4 control/{controlknobs,controlclient}: simplify knobs API, fix controlclient crash 
From integration tests elsewhere:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x70 pc=0x845c9b]

goroutine 226 [running]:
tailscale.com/control/controlclient.(*Direct).sendMapRequest(0xc00053e1e0, 0x16670f0, 0xc000353780, 0xffffffffffffffff, 0xc0003e5f10, 0x0, 0x0)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/direct.go:803 +0x19bb
tailscale.com/control/controlclient.(*Direct).PollNetMap(...)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/direct.go:574
tailscale.com/control/controlclient.(*Auto).mapRoutine(0xc00052a1e0)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/auto.go:464 +0x571
created by tailscale.com/control/controlclient.(*Auto).Start
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/auto.go:151 +0x65
exit status 2

Also remove types/opt.Bool API addition which is now unnecessary.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 2021-07-15 22:34:50 -07:00