tailscale/net
Brad Fitzpatrick 171ec9f8f4 control/{controlknobs,controlclient}: simplify knobs API, fix controlclient crash
From integration tests elsewhere:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x70 pc=0x845c9b]

goroutine 226 [running]:
tailscale.com/control/controlclient.(*Direct).sendMapRequest(0xc00053e1e0, 0x16670f0, 0xc000353780, 0xffffffffffffffff, 0xc0003e5f10, 0x0, 0x0)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/direct.go:803 +0x19bb
tailscale.com/control/controlclient.(*Direct).PollNetMap(...)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/direct.go:574
tailscale.com/control/controlclient.(*Auto).mapRoutine(0xc00052a1e0)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/auto.go:464 +0x571
created by tailscale.com/control/controlclient.(*Auto).Start
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/auto.go:151 +0x65
exit status 2

Also remove types/opt.Bool API addition which is now unnecessary.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
2021-07-15 22:34:50 -07:00
..
dns net/dns/resolver: upgrade forwarded MagicDNS queries to DoH when IP known 2021-07-15 12:03:52 -07:00
dnscache control/controlclient, net/{dnscache,dnsfallback}: add DNS fallback mechanism 2021-03-01 18:42:03 -08:00
dnsfallback ipn, etc: use controlplane.tailscale.com 2021-06-28 09:38:23 -07:00
flowtrack net/packet, wgengine/filter: support SCTP 2021-03-20 21:34:13 -07:00
interfaces net/interface: add AWS App Runner /proc/net/route test 2021-07-14 10:01:14 -07:00
netcheck net/{interfaces,netcheck}: rename some fields, funcs 2021-06-17 17:50:13 -07:00
netns netns_linux: remove special handling for tests. 2021-07-14 10:01:14 -07:00
netstat all: adapt to opaque netaddr types 2021-05-16 14:52:00 -07:00
nettest net/nettest: make nettest.NewConn pass x/net/nettest.TestConn. 2021-04-06 15:34:29 -07:00
packet net/packet: use netaddr AppendTo methods 2021-05-20 20:42:18 -07:00
portmapper control/{controlknobs,controlclient}: simplify knobs API, fix controlclient crash 2021-07-15 22:34:50 -07:00
socks5 net/socks5/tssocks: add a SOCKS5 dialer type, method-ifying code 2021-06-28 13:12:42 -07:00
speedtest Implemented Commandline Download Speedtest (#2064) 2021-07-15 14:43:13 -04:00
stun tstest/integration: add testNode.AwaitListening, DERP+STUN, improve proxy trap 2021-05-03 12:14:20 -07:00
tlsdial net/tlsdial, derp/derphttp: finish DERPNode.CertName validation 2020-06-01 09:01:37 -07:00
tsaddr net/tsaddr: simplify TailscaleServiceIP 2021-05-28 20:36:26 -07:00
tshttpproxy net/tshttpproxy: call winhttp calls from a fixed OS thread 2021-03-03 19:16:04 -08:00
tstun net/tstun: fix data races 2021-07-07 16:15:29 -07:00