mirrors
/
tailscale
mirror of https://github.com/tailscale/tailscale.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
tailscale/types
History
Brad Fitzpatrick 171ec9f8f4 control/{controlknobs,controlclient}: simplify knobs API, fix controlclient crash 
From integration tests elsewhere:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x70 pc=0x845c9b]

goroutine 226 [running]:
tailscale.com/control/controlclient.(*Direct).sendMapRequest(0xc00053e1e0, 0x16670f0, 0xc000353780, 0xffffffffffffffff, 0xc0003e5f10, 0x0, 0x0)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/direct.go:803 +0x19bb
tailscale.com/control/controlclient.(*Direct).PollNetMap(...)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/direct.go:574
tailscale.com/control/controlclient.(*Auto).mapRoutine(0xc00052a1e0)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/auto.go:464 +0x571
created by tailscale.com/control/controlclient.(*Auto).Start
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/auto.go:151 +0x65
exit status 2

Also remove types/opt.Bool API addition which is now unnecessary.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 		2021-07-15 22:34:50 -07:00
..
empty types/empty: add Message, stop using mysterious *struct{} 2020-02-14 13:35:49 -08:00
flagtype types/flagtype: fix bug showing the default port value (shown in --help) 2020-10-19 20:18:31 -07:00
ipproto net/packet, wgengine/filter: support SCTP 2021-03-20 21:34:13 -07:00
key staticcheck.conf: turn off noisy lint errors 2021-06-18 15:48:20 -07:00
logger types/logger: fix deadlock RateLimitedFn reentrancy 2021-06-25 08:38:08 -07:00
netmap all: adapt to opaque netaddr types 2021-05-16 14:52:00 -07:00
nettype wgengine/magicsock, tstest/natlab: start hooking up natlab to magicsock 2020-07-10 14:32:58 -07:00
opt control/{controlknobs,controlclient}: simplify knobs API, fix controlclient crash 2021-07-15 22:34:50 -07:00
pad32 net/portmapper: add NAT-PMP client, move port mapping service probing 2021-02-23 09:07:38 -08:00
persist types/persist: split controlclient.Persist into a small leaf package 2021-02-05 15:25:33 -08:00
preftype types/preftype: don't use iota for consts persisted to disk 2021-04-02 09:02:54 -07:00
structs types/structs: add structs.Incomparable annotation, use it where applicable 2020-05-03 14:05:32 -07:00
wgkey tailcfg, types/wgkey: add AppendTo methods on some types 2021-05-24 15:09:57 -07:00