mirrors
/
tailscale
mirror of https://github.com/tailscale/tailscale.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
tailscale/control/controlclient
History
Brad Fitzpatrick 171ec9f8f4 control/{controlknobs,controlclient}: simplify knobs API, fix controlclient crash 
From integration tests elsewhere:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x70 pc=0x845c9b]

goroutine 226 [running]:
tailscale.com/control/controlclient.(*Direct).sendMapRequest(0xc00053e1e0, 0x16670f0, 0xc000353780, 0xffffffffffffffff, 0xc0003e5f10, 0x0, 0x0)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/direct.go:803 +0x19bb
tailscale.com/control/controlclient.(*Direct).PollNetMap(...)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/direct.go:574
tailscale.com/control/controlclient.(*Auto).mapRoutine(0xc00052a1e0)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/auto.go:464 +0x571
created by tailscale.com/control/controlclient.(*Auto).Start
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/auto.go:151 +0x65
exit status 2

Also remove types/opt.Bool API addition which is now unnecessary.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
 		2021-07-15 22:34:50 -07:00
..
auto.go ipn/{ipnlocal,localapi}, control/controlclient: add SetDNS localapi 2021-06-07 20:35:56 -07:00
client.go ipn/{ipnlocal,localapi}, control/controlclient: add SetDNS localapi 2021-06-07 20:35:56 -07:00
controlclient_test.go ipnlocal: don't assume NeedsLogin immediately after StartLogout(). 2021-05-31 14:53:49 -04:00
debug.go tailcfg, control/controlclient: add goroutine dump debug feature 2021-03-03 10:56:01 -08:00
debug_test.go tailcfg, control/controlclient: add goroutine dump debug feature 2021-03-03 10:56:01 -08:00
direct.go control/{controlknobs,controlclient}: simplify knobs API, fix controlclient crash 2021-07-15 22:34:50 -07:00
direct_test.go all: adapt to opaque netaddr types 2021-05-16 14:52:00 -07:00
hostinfo_linux.go hostinfo: add hostinfo package, move stuff out of controlclient 2021-06-17 14:27:01 -07:00
hostinfo_windows.go control/controlclient: cache Windows version 2021-03-15 21:40:32 -07:00
map.go control/controlclient: add debug knob to force node to only IPv6 self addr 2021-06-28 15:26:58 -07:00
map_test.go tailcfg, control/controlclient: accept nil MapResponse.Node (mapver 18) 2021-04-19 11:53:21 -07:00
sign.go control/controlclient: sign RegisterRequest (#1549) 2021-03-26 10:01:08 -04:00
sign_supported.go control/controlclient: use our fork of certstore 2021-05-28 12:12:45 -04:00
sign_unsupported.go control/controlclient: sign RegisterRequest (#1549) 2021-03-26 10:01:08 -04:00
status.go ipnlocal: don't assume NeedsLogin immediately after StartLogout(). 2021-05-31 14:53:49 -04:00