ad5e04249b
One of the most common "unexpected" log lines is: "network state changed, but stringification didn't" One way that this can occur is if an interesting interface (non-Tailscale, has interesting IP address) gains or loses an uninteresting IP address (link local or loopback). The fact that the interface is interesting is enough for EqualFiltered to inspect it. The fact that an IP address changed is enough for EqualFiltered to declare that the interfaces are not equal. But the State.String method reasonably declines to print any uninteresting IP addresses. As a result, the network state appears to have changed, but the stringification did not. The String method is correct; nothing interesting happened. This change fixes this by adding an IP address filter to EqualFiltered in addition to the interface filter. This lets the network monitor ignore the addition/removal of uninteresting IP addresses. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com> |
||
|---|---|---|
| .. | ||
| interfaces.go | ||
| interfaces_darwin.go | ||
| interfaces_darwin_test.go | ||
| interfaces_default_route_test.go | ||
| interfaces_defaultrouteif_todo.go | ||
| interfaces_linux.go | ||
| interfaces_linux_test.go | ||
| interfaces_test.go | ||
| interfaces_windows.go | ||
| interfaces_windows_test.go | ||