tailscale/net/tshttpproxy
Brad Fitzpatrick fb392e34b5 net/tshttpproxy: don't ignore env-based HTTP proxies after system lookups fail
There was a mechanism in tshttpproxy to note that a Windows proxy
lookup failed and to stop hitting it so often. But that turns out to
fire a lot (no PAC file configured at all results in a proxy lookup),
so after the first proxy lookup, we were enabling the "omg something's
wrong, stop looking up proxies" bit for awhile, which was then also
preventing the normal Go environment-based proxy lookups from working.

This at least fixes environment-based proxies.

Plenty of other Windows-specific proxy work remains (using
WinHttpGetIEProxyConfigForCurrentUser instead of just PAC files,
ignoring certain types of errors, etc), but this should fix
the regression reported in #4811.

Updates #4811

Change-Id: I665e1891897d58e290163bda5ca51a22a017c5f9
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
2022-11-14 09:11:33 -08:00
..
mksyscall.go net/tshttpproxy: fix incorrect type in Windows implementation, switch to mkwinsyscall, fix memory leak 2022-07-27 16:33:57 -06:00
tshttpproxy.go net/tshttpproxy: don't ignore env-based HTTP proxies after system lookups fail 2022-11-14 09:11:33 -08:00
tshttpproxy_future.go all: remove old +build tags 2022-11-04 07:25:42 -07:00
tshttpproxy_linux.go all: remove old +build tags 2022-11-04 07:25:42 -07:00
tshttpproxy_synology.go all: remove old +build tags 2022-11-04 07:25:42 -07:00
tshttpproxy_synology_test.go all: remove old +build tags 2022-11-04 07:25:42 -07:00
tshttpproxy_test.go net/tshttpproxy: don't ignore env-based HTTP proxies after system lookups fail 2022-11-14 09:11:33 -08:00
tshttpproxy_windows.go net/tshttpproxy: add clientmetrics on Windows proxy lookup paths 2022-11-03 12:16:42 -07:00
zsyscall_windows.go net/tshttpproxy: fix incorrect type in Windows implementation, switch to mkwinsyscall, fix memory leak 2022-07-27 16:33:57 -06:00