History

Josh Bleecher Snyder bb8ce48a6b logtail: allow changing log level concurrently When tailscaled starts up, these lines run: func run() error { // ... pol := logpolicy.New("tailnode.log.tailscale.io") pol.SetVerbosityLevel(args.verbose) // ... } If there are old log entries present, they immediate start getting uploaded. This races with the call to pol.SetVerbosityLevel. This manifested itself as a test failure in tailscale.com/tstest/integration when run with -race: WARNING: DATA RACE Read at 0x00c0001bc970 by goroutine 24: tailscale.com/logtail.(Logger).Write() /Users/josh/t/corp/oss/logtail/logtail.go:517 +0x27c log.(Logger).Output() /Users/josh/go/ts/src/log/log.go:184 +0x2b8 log.Printf() /Users/josh/go/ts/src/log/log.go:323 +0x94 tailscale.com/logpolicy.newLogtailTransport.func1() /Users/josh/t/corp/oss/logpolicy/logpolicy.go:509 +0x36c net/http.(Transport).dial() /Users/josh/go/ts/src/net/http/transport.go:1168 +0x238 net/http.(Transport).dialConn() /Users/josh/go/ts/src/net/http/transport.go:1606 +0x21d0 net/http.(Transport).dialConnFor() /Users/josh/go/ts/src/net/http/transport.go:1448 +0xe4 Previous write at 0x00c0001bc970 by main goroutine: tailscale.com/logtail.(Logger).SetVerbosityLevel() /Users/josh/t/corp/oss/logtail/logtail.go:131 +0x98 tailscale.com/logpolicy.(Policy).SetVerbosityLevel() /Users/josh/t/corp/oss/logpolicy/logpolicy.go:463 +0x60 main.run() /Users/josh/t/corp/oss/cmd/tailscaled/tailscaled.go:178 +0x50 main.main() /Users/josh/t/corp/oss/cmd/tailscaled/tailscaled.go:163 +0x71c Goroutine 24 (running) created at: net/http.(Transport).queueForDial() /Users/josh/go/ts/src/net/http/transport.go:1417 +0x4d8 net/http.(Transport).getConn() /Users/josh/go/ts/src/net/http/transport.go:1371 +0x5b8 net/http.(Transport).roundTrip() /Users/josh/go/ts/src/net/http/transport.go:585 +0x7f4 net/http.(Transport).RoundTrip() /Users/josh/go/ts/src/net/http/roundtrip.go:17 +0x30 net/http.send() /Users/josh/go/ts/src/net/http/client.go:251 +0x4f0 net/http.(Client).send() /Users/josh/go/ts/src/net/http/client.go:175 +0x148 net/http.(Client).do() /Users/josh/go/ts/src/net/http/client.go:717 +0x1d0 net/http.(Client).Do() /Users/josh/go/ts/src/net/http/client.go:585 +0x358 tailscale.com/logtail.(Logger).upload() /Users/josh/t/corp/oss/logtail/logtail.go:367 +0x334 tailscale.com/logtail.(Logger).uploading() /Users/josh/t/corp/oss/logtail/logtail.go:289 +0xec Rather than complicate the logpolicy API, allow the verbosity to be adjusted concurrently. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>		2021-05-25 15:29:21 -07:00
..
backoff	backoff: update to Go style, document a bit, make 30s explicit	2020-08-09 09:36:26 -07:00
example	logtail, logpolicy: remove an unidiomatic use of an interface	2020-12-21 09:03:39 -08:00
filch	logtail/filch: add staticcheck annotation	2021-05-04 08:54:50 -07:00
.gitignore	Move Linux client & common packages into a public repo.	2020-02-09 09:32:57 -08:00
README.md	Move Linux client & common packages into a public repo.	2020-02-09 09:32:57 -08:00
api.md	Move Linux client & common packages into a public repo.	2020-02-09 09:32:57 -08:00
buffer.go	logtail: rename the unused CheckLogs to DrainLogs	2020-03-20 13:26:33 +11:00
id.go	logtail: reduce PublicID.UnmarshalText from 2 allocs to 0	2021-04-15 10:42:12 -07:00
id_test.go	logtail: add ParsePublicID that doesn't allocate	2020-04-13 08:54:35 -07:00
logtail.go	logtail: allow changing log level concurrently	2021-05-25 15:29:21 -07:00
logtail_test.go	logtail: reduce PublicID.UnmarshalText from 2 allocs to 0	2021-04-15 10:42:12 -07:00

README.md

Tailscale Logs Service

This github repository contains libraries, documentation, and examples for working with the public API of the tailscale logs service.

For a very quick introduction to the core features, read the API docs and peruse the logs reprocessing example.

For more information, write to info@tailscale.io.