tailscale/net/tshttpproxy
Aaron Klotz 4dbdb19c26 net/tshttpproxy: fix incorrect type in Windows implementation, switch to mkwinsyscall, fix memory leak
The definition of winHTTPProxyInfo was using the wrong type (uint16 vs uint32)
for its first field. I fixed that type.

Furthermore, any UTF16 strings returned in that structure must be explicitly
freed. I added code to do this.

Finally, since this is the second time I've seen type safety errors in this code,
I switched the native API calls over to use wrappers generated by mkwinsyscall.
I know that would not have helped prevent the previous two problems, but every
bit helps IMHO.

Updates https://github.com/tailscale/tailscale/issues/4811

Signed-off-by: Aaron Klotz <aaron@tailscale.com>
2022-07-27 16:33:57 -06:00
..
mksyscall.go net/tshttpproxy: fix incorrect type in Windows implementation, switch to mkwinsyscall, fix memory leak 2022-07-27 16:33:57 -06:00
tshttpproxy.go net/tshttpproxy: support HTTP proxy environment credentials on Windows too 2021-02-18 08:27:37 -08:00
tshttpproxy_future.go all: gofmt with Go 1.17 2021-08-05 15:54:00 -07:00
tshttpproxy_linux.go tshttpproxy: support synology proxy configuration 2022-04-21 18:39:00 -07:00
tshttpproxy_synology.go net/tshttpproxy: synology: pick proxy by scheme 2022-04-28 11:56:37 -07:00
tshttpproxy_synology_test.go net/tshttpproxy: synology: pick proxy by scheme 2022-04-28 11:56:37 -07:00
tshttpproxy_test.go net/tshttpproxy: support HTTP proxy environment credentials on Windows too 2021-02-18 08:27:37 -08:00
tshttpproxy_windows.go net/tshttpproxy: fix incorrect type in Windows implementation, switch to mkwinsyscall, fix memory leak 2022-07-27 16:33:57 -06:00
zsyscall_windows.go net/tshttpproxy: fix incorrect type in Windows implementation, switch to mkwinsyscall, fix memory leak 2022-07-27 16:33:57 -06:00