* move ChannelID to outside of functionGenControl
* move ChannelData out of functionGenControl
* make the genericUsbDriver fGenPtrs into an array
* Make genericUsbDriver store pointers to ChannelData instead of to functionGenControl
* split genericUsbDriver::setFunctionGen into two parts. Stop reassigning the fGen pointers
* Big functionGenControl refactor
- Create functionGen namespace
- Rename functionGenControl to DualChannelController
- Create a SingleChannelController class that holds all the
functionality of a single channel (i.e. almost all of it).
This class acts as a Qt wrapper over the actual data, it
gives it the ability to emit and recieve signals while
keeping the actual data copiable.
- Add an alias functionGenControl = DualChannelController
* fix brackets
* make serialBuffer a member of uartStyleDecoder and add m_ prefix, loosen synchcronization on updateConsole
* make uartStyleDecoder::updateTimer a member variable
* write isEvenParity lambda in a more concise way
* add unused attribute on decode_baudot. make isEvenParity take an argument
* add const where possible on uartStyleDecoder methods
* Refactor performParityCheck to immutability
* Move the computation around a bit. Parameterize with parameters instead of relying on class state
* remove parity!=Node check. isParityCorrect alreaddy checks this.
* Various changes regarding uartStyleDecoder.
- rename parent to m_parent
- store baud rate as a member variable
- use bool instead of unsigned char for single bit values
- remove maybe_unused attribute on decodeBaudot
- getUartBit(index) -> getNextUartBit()
* use an enum instead of int to identify function generator channels
* Use local 8 bit encoding instead of utf8 for file paths
* use static_cast instead of function-style casts
* remove length member from channelData struct. use reference captures on some lambdas
* Add struct definition for functionGenControl channel data
* Add member variables for channel data to functionGenControl, deprecate old variables
* fix a typo
* Transition to new functionGenControl cahnnel data variables. Remove old ones.
* refactor genericUsbDriver::setFunctionGen to use the new ChannelData struct.
* functionGenControl: free(NULL) is safe
* Eliminate duplication of functionGenControl::waveformName_CH* fuctions by putting common things into a private template function
* get rid of comments added during refactor
* Move function gen channel data to use std::vector. algorithmify some code on genericUsbDriver::setFunctionGen
* various formatting changes, remove irrelevant comments
* functionGenControl::waveformName: always use utf8 and 16 byte buffers. Remove template
* fix typo introduced by last-second indentation change
* genericUsbDrive::setFunctionGen: shrink samples to fit
* functionGenControl::waveformName: clean up file path manipulation, clean up formatting
* change the two channel objects to an array of two elements. Add common implementations for all methods of functionGenControl. Fix a massive bug introduced earlier in the refactor. Formatting.
* Start moving towards cstdint types. Change m_bufferEnd to m_bufferLen (i.e. dont substract 1 when constructing), this fixes a bunch of small bugs and off by one errors
* Fix loop in isoBuffer::getDelayedTriggerPoint not touching the first element
* Comments, formatting
* Reorder some of isobuffer.cpp's functions
* Fix compile error caused by not fully renaming a variable
* Fix some off-by-one errors
* formatting
* Tabs -> Spaces
* Split isoBuffer::maybeOutputSampleToFile into two functions
* reorder isoBuffer data members. clean up comments and formatting. clean isoBuffer::writeBuffer
* Remove my name from a comment
* Use type-safe Qt connect. Move comments. change IO column comparison.
* Give isoBuffer the proper ringBuffer behaviour
* Change the behaviour of isoBuffer::readBuffer; Change comments to reflect this.
* Fix a silly mistake in isobuffer.cpp (compiler warnings are awesome)
* Modify isoBuffer::readBuffer
* add destructor to isoBuffer, reorder initializer list. isobuffer.cpp now compiles with no warnings.
* Change isoBuffer::m_buffer to be a unique_ptr
* Change isoBuffer::m_stopDecoding to isoBuffer::m_isDecoding
* Refactor isoBuffer::readBuffer to use unique_ptr. Currently a memory leak
* Change signature of isoBuffer::readBuffer to return unique_ptr. adapt isoDriver acordingly.
* Clean up comments on isobuffer .h and .cpp
* Incorporate review comments: formatting, explicit unique_ptr, spelling
* make isobuffer.cpp follow the common bracket style
* Add a few utility functions to isoBuffer, and reorganize and comment isobuffer.h
* refactor a few functions in isoBuffer using the newly added functions
* Clean up isoBuffer::readBuffer. Requires particular attention during review
* remove unused variable isoBuffer::firstTime
* Fix formatting and add a comment to isoBuffer::maybeOutputSampleToFile
* move invariant out of loop in isoBuffer::writeBuffer_short
* Substantially refactor isoBuffer::readBuffer
* change spaces to tabs on isoBuffer.h
* spaces to tabs on isobuffer.cpp and isobuffer.h, but properly
* Enforce const correctness on some methods of isoBuffer
* Add some comments to isobuffer.cpp
* Remove duplication in isoBuffer::cap_xnfromxxx functions by extracting common functionality to a free function
* Format isobuffer.h and isobuffer.cpp
* add inserted count to isoBuffer
* further modification to isoBuffer::readBuffer
* Correct a comment in isoBuffer::readBuffer
* add an anonymous namespace with file-wide constants
* remove isoBuffer::openFile, and move initialization isoBuffer to initializer list
* add lines between if statements in isoBuffer::insertIntoBuffer
* add spaces after // to some comments
* extract common functionality from writeBuffer_xxx functions to function template
* update header file to reflect previous commits
* make isoBuffer::return nullptr in a troublesome case
* add space after // to some other comments
* Make capSample a member function of isoBuffer, delete a macro in isobuffer.cpp
* clean up various comments and declarations in isobuffer.cpp
* make isoBuffer::gainBuffer work for any gain value
* make enableFileIO use the constant definitions made in a recent commit
* Remove type argument from isoBuffer::serialManage
* make isoBuffer::readBuffer return a zero-filled buffer instead of null
* Remove isoBuffer::glitchInsert
* Add a bunch of TODOs to isobuffer.cpp and isobuffer.h
* Rename member variables of isoBuffer to have an m_ prefix
* Move isoBuffer::capSample comparison functors to anonymous namespace
* Make CONSOLE_UPDATE_TIMER_PERIOD on isobuffer.h a constexpr intead of a macro
* Update all code to use the new isoBufferBuffer interface, and remove the old one; also rename isoBufferBuffer::add(uint8_t) to insert_hex
* remove unnecessary include directive from isobuffer.h
* Remove 'Legacy Interface' comment from isoBufferBuffer header and implementation, move insert_hex closer to other insert functions in the header and implementation
* Remove TODO comment of a finished task
Chris Esposito
Sebastián Mestre
Chris Esposito