ipn/ipnserver: staticcheck is not wrong

shamecube.gif
2020-07-29 15:15:05 -07:00 · 2020-07-29 15:15:05 -07:00 · 9ff5b380cb
parent 4aba86cc03
commit 9ff5b380cb
1 changed files with 3 additions and 2 deletions
--- a/ipn/ipnserver/server.go
+++ b/ipn/ipnserver/server.go
@ -188,7 +188,6 @@ func Run(ctx context.Context, logf logger.Logf, logid string, getEngine func() (
 				continue
 			}
 			logf("%d: trying getEngine again...", i)
-			//lint:ignore SA4006 staticcheck is wrong
 			eng, err = getEngine()
 			if err == nil {
 				logf("%d: GetEngine worked; exiting failure loop", i)
@ -204,7 +203,9 @@ func Run(ctx context.Context, logf logger.Logf, logid string, getEngine func() (
 				s.Read(make([]byte, 1))
 			}()
 		}
-		return ctx.Err()
+		if err := ctx.Err(); err != nil {
+			return err
+		}
 	}

 	var store ipn.StateStore